1021391 - [VsD Refresh] Lockscreen Visual Refresh > Unlock icon too low

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Peter La]

Attachment: LockIconTooLow.jpg

The unlock icon in the lockscreen looks too low visually.  It needs to be moved up 3 pixels to appear visually centered.  See attachment.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: lock_screen_original.png

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: lock_screen_up2px_0.1rem.png

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: lock_screen_up3px_0.2rem.png

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8435506 [details]
lock_screen_up2px_0.1rem.png

Hi Peter,

I did some CSS manipulation and it appeared that upping 2px (0.1rem) seems to be visually better than upping 3px (0.2rem). Please see my attachments. So I'd like to confirm if you want to go with 2px or 3px? Thanks :)

Comment 5

[Peter La]

Comment on attachment 8435506 [details]
lock_screen_up2px_0.1rem.png

Hi John,

Appreciate your input, but I think I like the original ask to move it up 3 pixels better.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

Comment 7

[bhavana bajaj [:bajaj]]

Feel free to seek uplift when ready but this is not a blocker for release.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8436644 [details] [review]
Patch

Style changes, and tests passed. Go ahead and thanks for your help.

Comment 9

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/7ffd675e39e3e22283ed388b3faecdc3f0417962

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8436644 [details] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): bug 1021391 was because of not-to-spec implementation of bug 950884

[User impact] if declined: minimal, as this is only cosmetic change

[Testing completed]: Yes, both Travis and TBPL, with rebase against master just 1.5 hours ago

[Risk to taking this patch] (and alternatives if risky): minimal, as this is only cosmetic change

[String changes made]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/dd7a86e2464091148216354d82d3516d800ceee2

Comment 12

[Stephany Wilkes]

How is this approval+ with ui-review-? Please clarify.

Comment 13

[bhavana bajaj [:bajaj]]

(In reply to Stephany Wilkes from comment #12)
> How is this approval+ with ui-review-? Please clarify.

I assumed JOhn's patch addressed the UX comment and since it had landed on master with no further comments from anyone. If the patches are not ready, they should not be requesting approval.

Comment 14

[Stephany Wilkes]

Peter, can you verify whether ui-review is - or + here? Thank you!

Comment 15

[John Lu [:mnjul][Please NI or I'll miss]]

Hi there,
the 3px upping was made into CSS in the patch and it looked like exactly in one of my screenshots.

Comment 16

[Peter La]

Hi Stephany/John,

I tried building your branch but I got an error.  Can you just post a screenshot?

Thanks,
Peter.