1021418 - [Rocketbar] No easy way to clear search term and research

Status: VERIFIED DUPLICATE of bug 1023819

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Peter deHaan [:pdehaan]]

STR:
1. On the homescreen, type something long into the search bar.
2. Try and erase the search term.


Actual results:
No easy way to clear the search terms, apart from pressing down the backspace virtual key.
I'm accidentally pressing the "Close" button in the search field expecting it to be a clear button (similar to `<input type="search">`).

Comment 1

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Need input from UX team to check if this a bug or by design.

Comment 2

[Stephany Wilkes]

Pretty sure this is a bug. Double checking, though.

Comment 3

[Rob MacDonald [:robmac]]

Just checking the spec - https://mozilla.box.com/s/qbbhcsoaqwqwl9dce4mc - and there does not appear to be a method for clearing. I believe this is because it was replaced by and arrow button in the search field that can be used to trigger search. Added Francis to confirm and likely raise a bug for the missing arrow.

Comment 4

[Stephany Wilkes]

To add to Rob's comment (which is correct): being able to clear search is an established, expected OS-wide pattern. The visual is missing in the spec. I'm going to flag visual designers on this and see if they can attached the correct icon to this bug to get this out of our way for 2.0.

Comment 5

[Patryk Adamczyk [:patryk] UX]

Eric owns rocket bar.

Comment 6

[Eric Pang [:epang] UX]

(In reply to Patryk Adamczyk [:patryk] UX from comment #5)
> Eric owns rocket bar.

Francis, a while back we replaced the clear button with the arrow as (go/enter).  Should we bring back the clear icon?  Though this will mean that the user will need to press the enter key on the keyboard to go.

Comment 7

[Francis Djabri [:djabber]]

We originally included a "Go" button because we noticed some users failing to realize that they would need to press "Enter", and initiating a search is the most important use case. However, Stephany is right, we should conform to the general search pattern, and our plan was to include a clear button in any case once the Keyboard included a "Go" button. I've updated the spec to replace the "Go" button with a "Clear" button. Latest spec is available at:

https://mozilla.box.com/s/429tayahleyzy2uuql4m

Eric, could you provide the visuals?

Comment 8

[Eric Pang [:epang] UX]

(In reply to Francis Djabri [:djabber] from comment #7)
> We originally included a "Go" button because we noticed some users failing
> to realize that they would need to press "Enter", and initiating a search is
> the most important use case. However, Stephany is right, we should conform
> to the general search pattern, and our plan was to include a clear button in
> any case once the Keyboard included a "Go" button. I've updated the spec to
> replace the "Go" button with a "Clear" button. Latest spec is available at:
> 
> https://mozilla.box.com/s/429tayahleyzy2uuql4m
> 
> Eric, could you provide the visuals?

I've updated the spec and added a link to the image asset in the user story.

Comment 9

[Ben Francis [:benfrancis]]

What effect will this have on the full Rocketbar?

Currently in the Rocketbar spec this is a combined go/stop/refresh button, consistent with Firefox on Desktop and Firefox for Android. Where will the stop and refresh buttons go?

(Note: Firefox for Android doesn't have a clear button, it uses the same "highlight all text on focus" approach as the old spec.)

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Question: should we have words instead of icons like the browser?
Words will have an l10n impact wouldn't it?

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Also a small nit, should we have the word blue?  This is inconsistent with the rest of the ui where highlights and tapping will show the blue.

Comment 12

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #11)
> Also a small nit, should we have the word blue?  This is inconsistent with
> the rest of the ui where highlights and tapping will show the blue.

Hey Naoki, thanks for the feedback!  I think the icon works better in this cause since it takes up less space then text.  I've been trying to keep the RB visually clean and uncrowded as possible.  Plus translations for locales could end up being much longer which may cause text to overlap.  My two cents :).

Regarding the blue 'close'.  We choose the blue since white seemed too bright and garnered too much attention.  But I'll bring this up with the team and see what they think. Thanks!

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified dup.