102147 - table alignment not visible in AllTags mode

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Kathleen :Brade]

table alignment not visible in AllTags mode

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: test case for bug 102147

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Reviews needed on patch 1.0 please ;-)

Comment 4

[Charles Manske]

Ok, I see what you're doing; we shouldn't use margin-left for all tags mode since
it override's the user's CSS rules. But won't we have the same problem for 
the remaining 'margin-top' rules?
I'm not actually sure this should be fixed. "All Tags" mode certainly isn't 
intended to be WYSIWYG. E.g., we are overriding existing background images for
all elements now and still will be for some elements with Daniel's newer version 
of the code, and the location of elements certainly isn't accurate because of
theyellow images.
If we do want to do this, I'd suggest simply removing all margin-left and 
margin-top rules.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Charley: margin-top is different... you have 2 UI ways in #composer 
to modify the left margin (indent/outdent on one hand, alignment on the other)
but we have nothing comparable for the top margin. I just want to see something
being done when, in the AllTags view, I select a block and indent or align it.
Without the removal or those 'margin-left: 2px' declarations, we can't.

I agree that it is better to completely remove it instead of turning it into
a comment.

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Hmmm. I am unfortunately seeing a dependency between this bug and the CSSization
of Composer (bug 77705). Let me explain : 

the indentation of a block, that we do in HTML mode using a surrounding
blockquote, is done in CSS by a margin-left property on the block itself; of
course, no more blockquote.

To get the indent state of a block, I look at the computed value of 'margin-left',
not the specified value, because otherwise the indentation buttons will not work
correctly if the margin is set by embedded rules (instead of inline styles in
the STYLE attribute)....

If, in the AllTags mode, we disable all left margins, the computed value for
'margin-left' will always be the same whatever the user makes and it breaks the
indentation buttons.

conclusion : I really need a fix for the current bug.

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.1; Charley can you r= please ?

Comment 8

[Kathleen :Brade]

Comment on attachment 54846 [details] [diff] [review]
patch v1.1; Charley can you r= please ?

r=brade

Comment 9

[Charles Manske]

Comment on attachment 54846 [details] [diff] [review]
patch v1.1; Charley can you r= please ?

r=cmanske

Comment 10

[kinmoz]

Comment on attachment 54846 [details] [diff] [review]
patch v1.1; Charley can you r= please ?

sr=[e-mail]

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in trunk

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** Bug 106098 has been marked as a duplicate of this bug. ***

Comment 13

[michael wendell]

Verified on build 2001110903.