[tarako] power consumption is high when play music with FM is background

NEW
Assigned to

Status

Firefox OS
Gaia::FMRadio
P1
normal
4 years ago
3 years ago

People

(Reporter: Peipei Cheng (needinfo if you need my action), Assigned: Xinhe Yan)

Tracking

({perf})

unspecified
Other
Other

Firefox Tracking Flags

(tracking-b2g:backlog, b2g-v1.3T affected)

Details

(Whiteboard: [c=power p= s= u=tarako] [sprd319139][partner-blocker])

Attachments

(1 attachment)

Created attachment 8435491 [details] [diff] [review]
bug319139_fm_should_be_power_off_if_audio_muted.patch

Steps to reproduce
---------------------------------------------------------------------------
1. Launch FM and play
2. Send FM to background
3. Launch Music and play

during spreadtrum's power consumption test, they found that the power consumption of this case consume 50mA more power than only playing music.

After developper's analysis, they found that, it's because FM trout was not closed when music starts.

attached is jesse.ji@spreadtrum.com's patch.
Hi james/Jesse, my concern is whether this change will affect the case that:
1. resume FM from phone call
2. resume FM from music.
Flags: needinfo?(jesse.ji)
Flags: needinfo?(james.zhang)
Whiteboard: [sprd319139][partner-blocker]
Our QA's concern is that power consumption is very high if don't close FM when music playback.
blocking-b2g: --- → 1.3T?
status-b2g-v1.3T: --- → affected
Flags: needinfo?(ttsai)
Flags: needinfo?(kkuo)
Flags: needinfo?(james.zhang)

Comment 3

4 years ago
(In reply to pcheng from comment #1)
> Hi james/Jesse, my concern is whether this change will affect the case that:
> 1. resume FM from phone call
> 2. resume FM from music.

Well, we actually could not restore FM playing automatically if power off FM.
Flags: needinfo?(jesse.ji)
Keywords: perf
Let xinhe implement FM mute interface and see power consumption.
Assignee: nobody → xinhe.yan
Flags: needinfo?(xinhe.yan)
Attachment #8435491 - Flags: review-
Component: General → Gaia::FMRadio
(Assignee)

Comment 5

4 years ago
I need assess all the solution(mute\just disable fm\disable audio connection).
Assignee: xinhe.yan → nobody
Flags: needinfo?(xinhe.yan)
(Assignee)

Comment 6

4 years ago
When enter music, fm is running background. 
But voice not came back when close music. 

I think we can add a notification to alert end user. Like music. 
This will decrease power consume.
brcm fm current is 27ma. trout chip is around 46ma.
1.3T+
it seems like you are working on this so i assign this bug to you xinhe
can we not change the behavior the end users are seeing? not sure why would end users need to see notifications to resolve such bug. thanks
Assignee: nobody → xinhe.yan
blocking-b2g: 1.3T? → 1.3T+
Priority: -- → P1
Whiteboard: [sprd319139][partner-blocker] → [sprd319139][partner-blocker][c=power p= s= u=tarako]
(Assignee)

Comment 8

4 years ago
(In reply to Joe Cheng [:jcheng] from comment #7)
> 1.3T+
> it seems like you are working on this so i assign this bug to you xinhe
> can we not change the behavior the end users are seeing? not sure why would
> end users need to see notifications to resolve such bug. thanks
This bug can not fix in sprd. All the control logic is in gecko.

I just checked samsung glaxy ace nxd.
1 Enter FM
2 Enter Music.  I think FM is disabled to save power.(Not sure, I can not get samsung code.)
3 Pause Music.  No FM voice. There were a notification to indicate FM is in background. Use can turn on FM  in notification. Our android will resume FM voice.

For Tarako,
1 Enter FM
2 Enter Music.  FM background and not disabled. This will consume power.
3 Pause Music.  No FM voice and no FM item in notification.

Since ffos not resume FM voice, can we just disable FM in step 2? 
Or give a end user a alert in notification. When end user drop notification, they will see FM is running on background. 
Anyway, this depend on how ffos design.

And all the control logic is in gecko. sprd only supply interface for gecko.
This can not be fixed in sprd.
(Assignee)

Comment 9

4 years ago
(In reply to Xinhe Yan from comment #8)
> Since ffos not resume FM voice, can we just disable FM in step 2? 
> Or give a end user a alert in notification. When end user drop notification,
> they will see FM is running on background. 
> Anyway, this depend on how ffos design.
This is not a critical bug, at least for now.

At step 3, our PM checked other reference phones like XiaoMi.
Some resume FM, some not. And most cases are not resume FM voice.

Updated

4 years ago
Flags: needinfo?(kkuo)

Comment 10

4 years ago
Joe,
Per Xinhe's comment 9, should this bug be removed from the blockers list?

(In reply to Xinhe Yan from comment #9)
> ...
> This is not a critical bug, at least for now.
> 
> At step 3, our PM checked other reference phones like XiaoMi.
> Some resume FM, some not. And most cases are not resume FM voice.
Severity: normal → blocker
Flags: needinfo?(jcheng)
Whiteboard: [sprd319139][partner-blocker][c=power p= s= u=tarako] → [c=power p= s= u=tarako] [sprd319139][partner-blocker]

Updated

4 years ago
Flags: needinfo?(ttsai)

Updated

4 years ago
Target Milestone: --- → 2.0 S5 (4july)
let's take this off the blockers list
blocking-b2g: 1.3T+ → backlog
Flags: needinfo?(jcheng)

Updated

4 years ago
Severity: blocker → normal
Target Milestone: 2.0 S5 (4july) → ---
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.