1021513 - [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

After solving the bug 1003820, the recipient list comes out another weird issue  mentioned in bug 1003820 comment 26. The list will scroll up to the bottom automatically when user drag down the list to see whole recipient list. Here is the reproduce step:

1) Add tons of recipients and make sure the recipient list is scrollable
2) Scroll to the top and tap somewhere else to make the recipient list back to single line mode.
3) Swip down the recipient list, the list will display as scrolling to the top and it will scroll to bottom later automatically.

BTW it didn't break the layout, it's just a confusing use experience that list scolled automatically.

Comment 1

[Julien Wajsberg [:julienw]]

I'll do a video.

Comment 2

[Julien Wajsberg [:julienw]]

Steve, I can't get the GestureDetector to detect anything on current master... does it work for you?

Comment 3

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Steve, I can't get the GestureDetector to detect anything on current
> master... does it work for you?

The Gesture works fine for me with master today, but it's based on old gecko (6/3) which might unrelated to your problem. But I can flash both for another try if you still stuck in this issue.

Comment 4

[Steve Chung [:steveck]]

Attachment: Video about recipient list scrolling

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8436895 [details]
Video about recipient list scrolling

Video link to youtube: http://youtu.be/BmLhYVpkQ-g

Comment 6

[Julien Wajsberg [:julienw]]

I've seen that we don't slide if there are only 2 lines. I'm filing a new bug.

Comment 7

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> I've seen that we don't slide if there are only 2 lines. I'm filing a new
> bug.


OK, now I can reproduce it with specific steps:

1) Create a multi-recipient message and save as draft (gesture works now)
2) Close message app, and launch again
3) Open the draft again, and the gesture could not work(even create another message)

Comment 8

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 9

[bhavana bajaj [:bajaj]]

Is this is a DUP of 1022644?

Comment 10

[Lionel Mauritson]

(In reply to bhavana bajaj [:bajaj] from comment #9)
> Is this is a DUP of 1022644?

In that bug it is specified that it must be 2 lines for the list of contacts to become un-viewable (as in comment 7), but I have this happen with any amount of contacts (larger than just 1, obviously). I was not able to actually reproduce the bug in comment 0. I was able to reproduce the bug in comment 7 on most builds (as can be seen below)


(In reply to Jason Smith [:jsmith] from comment #8)
> QA Wanted to check 1.4.

I spent time gathering all the information so I'll post it anyways just in case.

>In the following builds the issue in comment 0 does NOT occur. The issue in comment 7 does NOT occur.

Device: Buri 1.4
Build ID: 20140613000202
Gaia: 1dae62556e642b0b2e08689e35e24e56daa8c79b
Gecko: 30224c7f5e58
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg

Device: Open_C 1.4
Build ID: 20140613000202
Gaia: 1dae62556e642b0b2e08689e35e24e56daa8c79b
Gecko: 30224c7f5e58
Version: 30.0 (1.4) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

>In the following build the issue in comment 0 does NOT occur, though the issue in comment 7 DOES occur after following the steps.
 
Device: Flame 1.4
Build ID: 20140612000202
Gaia: 7fc73d4cb1bece31f50e8ccf6fb98af3984a9ebf
Gecko: bcd308fbbf38
Version: 30.0 (1.4) 
Firmware Version: v121-2


>In the following builds the I was not able to check the issue in comment 0 due to the issue in comment 7. 
>I cant bring down the list of contacts at all even if I don't follow the steps.

Device: Buri 2.0
BuildID: 20140612000201
Gaia: 2bb66630315299ca947e40fcec23c9f7ea012111
Gecko: 670d69879f0e
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg

Device: Flame 2.0
BuildID: 20140613000203
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 8897bc43f59b
Version: 32.0a2 (2.0) 
Firmware Version: v121-2

Device: Flame 2.1 - Master
Build ID: 20140612173627
Gaia: 5b4b4fc17a8e4a513a977f7062ea3e65d26ce268
Gecko: 48eee276b1ee
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2

Device: Open_C 2.1 - Master
BuildID: 20140612160203
Gaia: 90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko: aab3362f97e9
Version: 33.0a1 (2.1 - Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Device: Open_C 2.0
Build ID: 20140613000203
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 8897bc43f59b
Version: 32.0a2 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 11

[Julien Wajsberg [:julienw]]

Sorry for the confusion.

Yes, the STR in comment 7 is bug 1022644, we actually filed that bug specifically to address it.

This bug is about the comment 0 description. You need to have enough recipients to make the recipient panel scrollable when it's open.

Now, we know it's a regression from bug 1003820 and other visual refresh bugs, but please request qawanted again if you want a confirmation.

Comment 12

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Oleg, This patch modified the listener of transitionend event because the original listener could not receive the event when back to single line mode, and only scroll to bottom when entering the multiline mode.

Comment 13

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8447086 [details] [review]
Link to github

Looks good! r=me

Thanks

Comment 14

[Steve Chung [:steveck]]

Thanks for the review! Since we already created the corresponding bugs for failed tests(bug 1030764 in everyting.me and bug 1032037 in music). It should be fine to land this patch.

master: 517ac22e4342fff190e9ac71957174b0df3decc9

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/d631e9ac87a93f37b18f3d6feb71dd520c1aae38

Comment 16

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0