1021538 - Use mozmake to build comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use mozmake to build comm-central

The pymake.py change is straight out of m-c's pymake (bug 927672)
The tooltool manifest also comes from m-c (same bug).

Presumably, if the seamonkey slaves are not using tooltool, they won't get mozmake.exe, and as a result pymake will fall through to using plain pymake. But I don't know whether they do or not.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=581d1f229c2c

The python/foo thing in the try changeset is a workaround for bug 1021375.

Comment 2

[Mike Hommey [:glandium]]

Damn, that was close. The compile went through, but buildsymbols failed.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Use mozmake to build comm-central

The fix for buildsymbols was trivial:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e90f7739545a

Then I hit check-sync-dirs, which complains about the manifest I added not matching the one in m-c. Meh, the difference is sccache and setup.sh, those won't hurt and won't be used anyways, since m-c will look for it in $topsrcdir/mozilla and won't find it.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=dbe6ab581ee4

This last try is what this patch corresponds to.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8435652 [details] [diff] [review]
Use mozmake to build comm-central

Review of attachment 8435652 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/pymake/make.py
@@ +23,5 @@
> +    if 'TINDERBOX_OUTPUT' in os.environ:
> +        # When building on mozilla build slaves, execute mozmake instead. Until bug
> +        # 978211, this is the easiest, albeit hackish, way to do this.
> +        mozmake = os.path.join(os.path.dirname(__file__), '..', '..',
> +            'mozmake.exe')

I was actually surprised that this works, but the try runs convinced me that it does.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/comm-central/rev/9e17f6ef6620

Comment 6

[:aceman]

Looks like the change is for Windows only, but the bug is filed under Linux... Can you fix the Platform?