Closed Bug 1021538 Opened 7 years ago Closed 7 years ago
Use mozmake to build comm-central
No description provided.
The pymake.py change is straight out of m-c's pymake (bug 927672) The tooltool manifest also comes from m-c (same bug). Presumably, if the seamonkey slaves are not using tooltool, they won't get mozmake.exe, and as a result pymake will fall through to using plain pymake. But I don't know whether they do or not. https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=581d1f229c2c The python/foo thing in the try changeset is a workaround for bug 1021375.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Damn, that was close. The compile went through, but buildsymbols failed.
The fix for buildsymbols was trivial: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e90f7739545a Then I hit check-sync-dirs, which complains about the manifest I added not matching the one in m-c. Meh, the difference is sccache and setup.sh, those won't hurt and won't be used anyways, since m-c will look for it in $topsrcdir/mozilla and won't find it. https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=dbe6ab581ee4 This last try is what this patch corresponds to.
Comment on attachment 8435652 [details] [diff] [review] Use mozmake to build comm-central Review of attachment 8435652 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/pymake/make.py @@ +23,5 @@ > + if 'TINDERBOX_OUTPUT' in os.environ: > + # When building on mozilla build slaves, execute mozmake instead. Until bug > + # 978211, this is the easiest, albeit hackish, way to do this. > + mozmake = os.path.join(os.path.dirname(__file__), '..', '..', > + 'mozmake.exe') I was actually surprised that this works, but the try runs convinced me that it does.
Attachment #8435652 - Flags: review?(Pidgeot18) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Looks like the change is for Windows only, but the bug is filed under Linux... Can you fix the Platform?
You need to log in before you can comment on or make changes to this bug.