use "$(SEP)" instead of "/" for app-makefile-template

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yurenju, Assigned: yurenju)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

we use "/" for app-makefile-template and it caused error if build twice on Windows.
Created attachment 8435619 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20132
Assignee: nobody → yurenju.mozilla
try:
https://tbpl.mozilla.org/?tree=Try&rev=6db37557b4c3
Comment on attachment 8435619 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20132

George, could you review this pr? thanks!
Attachment #8435619 - Flags: review?(gduan)
Comment on attachment 8435619 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20132

LGTM, r=gduan
Attachment #8435619 - Flags: review?(gduan) → review+
merged.

https://github.com/mozilla-b2g/gaia/commit/9852534090a97b9fc2a664cab71b2bbd4f6d8776
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.