10216 - {css2} caption-side, not vertical-align, should be equivalent to align on caption

Status: VERIFIED DUPLICATE of bug 3166

(Core :: Layout: Tables, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The align attribute of the HTML 4.0 caption element is not supported for the
left and right values.  bottom does seem to work though.  Test case to be
attached.

The Right Way (tm) to do this is by supporting the CSS2 caption-side property,
and mapping align to it (and not much harder, either, I would think).  Right
now, caption-side doesn't work at all.  See:
http://www.fas.harvard.edu/~dbaron/css/test/sec1704
http://www.fas.harvard.edu/~dbaron/css/test/sec1704b
http://www.fas.harvard.edu/~dbaron/css/test/sec170401

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test case for caption element, align attribute

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The third test above seems to show that you are incorrectly mapping align on
captions to vertical-align, and then using vertical-align: bottom to mean
caption-side: bottom.

Comment 3

[Christine Hoffman]

David:
Please check out bug #3166 that I wrote up and see if you deem this one to be a
duplicate. That bug was marked 'Later' as it is officially out for 1.0 per
[e-mail].

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Part of it (the hard part to fix) is a dup of that bug.  However, the mapping
through vertical-align rather than caption-side is really wrong and should be
fixed (and is probably quite easy to fix for someone who knows the code - in
fact, I could probably even find it, but it would take me ten times as long).

Therefore, I'm going to reopen, and change the title from "{html40} align on
caption mostly not supported" to "caption-side, not vertical-align, should be
equivalent to align on caption".

karnaze:  because of the partial implementation of align, if you don't want
caption-side to work at all, that's reasonable (although a little silly,
perhaps).  But if align on captions maps to any CSS property, it should be
caption-side.  vertical-align on captions should act like it does on table-cells
- and perhaps it should be implemented that way.  The current behavior of
'vertical-align: bottom' putting the whole caption on the bottom is a serious
bug.  vertical-align really only applies to left or right captions, which you
don't support.  (There are some errors in my tests, I just realized...)

Comment 5

[Nicholas Cull]

Marking [TESTCASE].

Comment 6

[karnaze (gone)]

This is fixed except for caption-size left and right which we decided would not
make it into Release 1. Marking "later".

Comment 7

[Christine Hoffman]

Verified LATER.

Comment 8

[Hixie (not reading bugmail)]

This is now a dup of bug 3166, as mentioned above. Resolving as dup.

Comment 9

[Hixie (not reading bugmail)]

*** This bug has been marked as a duplicate of 3166 ***

Comment 10

[Christine Hoffman]

Verified dup of #3166

Comment 11

[Hixie (not reading bugmail)]

Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddb3ea2900f5
[components] Issue https://github.com/mozilla-mobile/android-components/issues/10216: Refactor LoginPickerView to a more generic view SelectablePromptView