1021676 - Fix and re-enable test_delay_load.html on B2G

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This has been disabled for a long time, but AFAICT no bug was ever filed for the failures.

https://tbpl.mozilla.org/php/getParsedLog.php?id=41178921&tree=Try

22:36:17     INFO -  1308 INFO TEST-START | /tests/content/media/test/test_delay_load.html
22:36:18     INFO -  ###################################### forms.js loaded
22:36:19     INFO -  ############################### browserElementPanning.js loaded
22:36:19     INFO -  ######################## BrowserElementChildPreload.js loaded
22:36:19     INFO -  1309 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_delay_load.html | 320x240.ogv:1 is not ready before onload fired (0)
22:36:19     INFO -  1310 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_delay_load.html | 320x240.ogv:1 is not ready before onload fired (0)
22:36:19     INFO -  1311 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_delay_load.html | 320x240.ogv:2 is not ready before onload fired (0)
22:36:19     INFO -  1312 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_delay_load.html | 320x240.ogv:3 is not ready before onload fired (0)
22:36:19     INFO -  1313 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_delay_load.html | 320x240.ogv:4 is not ready before onload fired (0)
22:36:20     INFO -  1314 INFO TEST-INFO | MEMORY STAT vsize after test: 121913344
22:36:20     INFO -  1315 INFO TEST-INFO | MEMORY STAT residentFast after test: 53977088
22:36:20     INFO -  1316 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 28588572
22:36:21     INFO -  1317 INFO TEST-END | /tests/content/media/test/test_delay_load.html | finished in 3984ms

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1021676_fix_test_delay_load_html_on_B2G.patch

Set preload to 'metadata' to ensure the readyState is at least HAVE_CURRENT_DATA.

Try on B2G opt: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9005a1edfa5c&searchQuery=b2g_emulator_vm%20try%20opt%20test%20mochitest-3

Try on B2G debug: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9005a1edfa5c&searchQuery=b2g_emulator_vm%20try%20debug%20test%20mochitest-debug-5

No failures in test_delay_load.html.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8502225 [details] [diff] [review]
1021676_fix_test_delay_load_html_on_B2G.patch

Review of attachment 8502225 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/mochitest.ini
@@ +347,5 @@
>  [test_decode_error.html]
>  [test_decoder_disable.html]
>  [test_defaultMuted.html]
>  [test_delay_load.html]
> +skip-if = buildapp == 'b2g' && toolkit != 'gonk' # crash on b2g-desktop

Is there a bug filed for this crash? After all the cleanup work I did in this manifest, I'm reticent to land changes to what's disabled without having corresponding bugs referenced.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1021676_fix_test_delay_load_html_on_B2G-v2.patch

Annotate bug 1021676 to track the disabled tests on B2G desktop.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Hi Ryan,
Can you help check in 1021676_fix_test_delay_load_html_on_B2G-v2.patch? Thanks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

The trees were closed most of yesterday. checkin-needed is still enough to get my attention.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75e03e9d1c31

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75e03e9d1c31