1021682 - Fix and re-enable test_streams_gc.html on B2G

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This has been disabled for a long time, but AFAICT no bug was ever filed for the failures.

https://tbpl.mozilla.org/php/getParsedLog.php?id=41178327&tree=Try

22:13:28     INFO -  53 INFO TEST-START | /tests/content/media/test/test_streams_gc.html
22:13:31     INFO -  *** UTM:SVC TimerManager:registerTimer - id: user-agent-updates-timer
22:13:33     INFO -  54 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_streams_gc.html | uncaught exception - TypeError: Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value. at http://mochi.test:8888/tests/content/media/test/test_streams_gc.html:38
22:13:33     INFO -  JavaScript error: http://mochi.test:8888/tests/content/media/test/test_streams_gc.html, line 38: Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value.
22:13:34     INFO -  55 INFO TEST-INFO | MEMORY STAT vsize after test: 109203456
22:13:34     INFO -  56 INFO TEST-INFO | MEMORY STAT residentFast after test: 41103360
22:13:34     INFO -  57 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 22307404
22:13:34     INFO -  58 INFO TEST-END | /tests/content/media/test/test_streams_gc.html | finished in 6169ms

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1021682_fix_test_streams_gc_html.patch

Add preload='metadata' to ensure we get a valid duration when running the test.

Try: https://tbpl.mozilla.org/?tree=Try&rev=3508ad9e51cc
     https://tbpl.mozilla.org/?tree=Try&rev=1d4c97c4af8d
All green.

Comment 2

[Carsten Book [:Tomcat]]

Hi, this patch failed to cleanly:

applying 1021682_fix_test_streams_gc_html.patch
patching file dom/media/test/mochitest.ini
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/media/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1021682_fix_test_streams_gc_html.patch

could you take a look? thanks!

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Weird. I can apply it cleanly on both latest central and inbound. Can you send me dom/media/test/mochitest.ini.rej to see where the conflict is?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Maybe a conflict with another applied patch. Anyway, it was a trivial rebase. I've got it queued.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab001e4e0efe

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab001e4e0efe