Closed Bug 1021682 Opened 6 years ago Closed 5 years ago

Fix and re-enable test_streams_gc.html on B2G

Categories

(Core :: Audio/Video, defect)

29 Branch
ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: RyanVM, Assigned: jwwang)

References

Details

Attachments

(1 file)

This has been disabled for a long time, but AFAICT no bug was ever filed for the failures.

https://tbpl.mozilla.org/php/getParsedLog.php?id=41178327&tree=Try

22:13:28     INFO -  53 INFO TEST-START | /tests/content/media/test/test_streams_gc.html
22:13:31     INFO -  *** UTM:SVC TimerManager:registerTimer - id: user-agent-updates-timer
22:13:33     INFO -  54 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_streams_gc.html | uncaught exception - TypeError: Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value. at http://mochi.test:8888/tests/content/media/test/test_streams_gc.html:38
22:13:33     INFO -  JavaScript error: http://mochi.test:8888/tests/content/media/test/test_streams_gc.html, line 38: Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value.
22:13:34     INFO -  55 INFO TEST-INFO | MEMORY STAT vsize after test: 109203456
22:13:34     INFO -  56 INFO TEST-INFO | MEMORY STAT residentFast after test: 41103360
22:13:34     INFO -  57 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 22307404
22:13:34     INFO -  58 INFO TEST-END | /tests/content/media/test/test_streams_gc.html | finished in 6169ms
Blocks: 1022453
Add preload='metadata' to ensure we get a valid duration when running the test.

Try: https://tbpl.mozilla.org/?tree=Try&rev=3508ad9e51cc
     https://tbpl.mozilla.org/?tree=Try&rev=1d4c97c4af8d
All green.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8517138 - Flags: review?(cpearce)
Attachment #8517138 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
Hi, this patch failed to cleanly:

applying 1021682_fix_test_streams_gc_html.patch
patching file dom/media/test/mochitest.ini
Hunk #1 FAILED at 491
1 out of 1 hunks FAILED -- saving rejects to file dom/media/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1021682_fix_test_streams_gc_html.patch

could you take a look? thanks!
Flags: needinfo?(jwwang)
Weird. I can apply it cleanly on both latest central and inbound. Can you send me dom/media/test/mochitest.ini.rej to see where the conflict is?
Flags: needinfo?(jwwang)
Maybe a conflict with another applied patch. Anyway, it was a trivial rebase. I've got it queued.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab001e4e0efe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.