1021735 - [Flame] Investigate and fix failure in test_import_contacts_from_sdcard.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

test_import_contacts_from_sdcard.py failed in the latest v2.0 build. 
I was able to reproduce the failure by running the automated test, but not manually
As I noticed, the Back button from was not tapped. Please investigate and fix the issue

Traceback (most recent call last):
  File "/home/viorelaioia/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sdcard.py", line 31, in test_import_contacts_from_sdcard
    contacts_settings.tap_back_from_import_contacts()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/settings_form.py", line 86, in tap_back_from_import_contacts
    self.wait_for_element_not_displayed(*self._back_from_import_contacts_locator)
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 48, in wait_for_element_not_displayed
    lambda m: not m.find_element(by, locator).is_displayed())
  File "/home/viorelaioia/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.0 seconds
TEST-UNEXPECTED-FAIL | test_import_contacts_from_sdcard.py test_import_contacts_from_sdcard.TestImportContactsFromSDCard.test_import_contacts_from_sdcard | 

#ENV: 
Gaia      857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko     https://hg.mozilla.org/mozilla-central/rev/c8288d0c7a15
BuildID   20140606040202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Jenkins report: http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Flame/job/b2g.flame.mozilla-central.ui.non-smoketest/54/HTML_Report/

Comment 1

[Jason Smith [:jsmith]]

Are we claiming this is a bug in the test or an actual Gaia bug?

Comment 2

[Viorela Ioia [:viorela]]

This is a bug in the test, it is not a Gaia bug.
I'm able to reproduce the failure intermittently, by running the automated test. 
I think we need to improve a wait in the test. I will open a PR with a fix.

Comment 3

[Viorela Ioia [:viorela]]

Attachment: PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/20269

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8437643 [details] [review]
PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/20269

lgtm

Comment 5

[Florin Strugariu [:Bebe]]

Comment on attachment 8437643 [details] [review]
PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/20269

This should go first on master and then we can make a uplift

Comment 6

[Zac C (:zac)]

I'll land this into 2.1 as it is not risky

Comment 7

[Zac C (:zac)]

Comment on attachment 8437643 [details] [review]
PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/20269

r+ from me

Comment 8

[Zac C (:zac)]

2.1 landed:
https://github.com/mozilla-b2g/gaia/commit/0dd795f6914d9caa4c8f66baec9858d5641ba256
2.0 landed:
https://github.com/mozilla-b2g/gaia/commit/aa3119ef01f42c5663759768fcc88c0a099b86d7