1021831 - Project Editor: show "Validation status" tooltip over the status circle in app manager header

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Brian Grinstead [:bgrins]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1019676#c5

Hovering the bullet should show a tooltip: "Validation status: ..."

Comment 1

[Brian Grinstead [:bgrins]]

There is a property called 'validationStatus' that gets passed into the project editor from webide.js [0].  Here is where it is documented [1], implemented [2], and tested [3] within the project editor.  This case involves a new string field (maybe named 'validationTooltip') for setting the tooltip on that circle, and it will more or less be a copy of that validationStatus property.


[0]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#414
[1]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/lib/projecteditor.js#359
[2]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/lib/plugins/app-manager/plugin.js#61
[3]: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/test/browser_projecteditor_app_options.js#47

Comment 2

[Brian Grinstead [:bgrins]]

And it is easier for developing to work at this URL: chrome://browser/content/devtools/projecteditor-loader.xul, and modify devtools/projecteditor/chrome/content/projecteditor-loader.js's call to setProjectToAppPath to add the new option.  This workflow is better for me at least than opening the WebIDE constantly while making projecteditor changes.  Plus you can use the normal toolbox on the page.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Jan, do you think you could take this one?  We're hoping to enable WebIDE for 34, so there's only a few weeks left.  Let me know if you don't have time.

Comment 4

[Jan Keromnes [:janx]]

On it.

Comment 5

[Jan Keromnes [:janx]]

Attachment: Show "Validation status" tooltip over the status circle in WebIDE.

Comment 6

[Jan Keromnes [:janx]]

Attachment: screenshot (invisible mouse pointer)

Comment 7

[Jan Keromnes [:janx]]

Note: I used WebIDE's localization and not Itchpad/Project Editor's localization.
My thinking was that the project validation status has more to do with the IDE than the editor, but it causes some Project Editor strings to be in "webide.properties" instead of "projecteditor.properties".

If that's ok, can you please land this patch?

I'll get around to requesting level 3 soon so that I can stop bothering you :)

Comment 8

[Paul Rouget [:paul]]

webide's localization in the app-manager plugin. So that's ok.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/acbf8144c773

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/acbf8144c773