1021851 - [Notes] read-only warning not localizable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Notes, defect)

Description

[Dylan Oliver [:doliver]]

The is a string defined for the "attachment too large" warning but we aren't using it in the code so all locales are seeing it in english.

String:
warning=(Some large images or attachments cannot be downloaded. Note is read only.)


index.html:
 <div id="warning">
   <i>(Some large images or attachments cannot be downloaded. Note is read only.)</i>
</div>

Comment 1

[Dylan Oliver [:doliver]]

Attachment: master PR

Comment 2

[Dylan Oliver [:doliver]]

Attachment: phase2 PR

Comment 3

[Yan Or]

Dylan,

I don't see "warning" strings defined for the other languages under locales dir.
The code looks good.

Comment 4

[Dylan Oliver [:doliver]]

Yes, most of the other localizations are out of date -- that's my next task but this will at least clear the path when they are ready.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/notes/commit/9765440ba12f8705da1fb2934ab626fa5fdfadfa

The phase2 PR needs rebasing before it can be merged.

Comment 6

[Dylan Oliver [:doliver]]

Attachment: updated phase2 PR

Fixed up PR, carried forward :yor's r+

Comment 7

[Dylan Oliver [:doliver]]

Thanks Ryan, phase2 should be ready for merging now.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

phase2: https://github.com/mozilla-b2g/notes/commit/58124da2611adbdb28e709aa450a2afbe92ed5d7