[Notes] read-only warning not localizable

RESOLVED FIXED in 2.0 S4 (20june)

Status

Firefox OS
Gaia::Notes
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: doliver, Assigned: doliver)

Tracking

({l12y})

unspecified
2.0 S4 (20june)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [priority])

Attachments

(2 attachments, 1 obsolete attachment)

44 bytes, text/x-github-pull-request
Yan Or
: review+
Details | Review | Splinter Review
44 bytes, text/x-github-pull-request
doliver
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
The is a string defined for the "attachment too large" warning but we aren't using it in the code so all locales are seeing it in english.

String:
warning=(Some large images or attachments cannot be downloaded. Note is read only.)


index.html:
 <div id="warning">
   <i>(Some large images or attachments cannot be downloaded. Note is read only.)</i>
</div>
(Assignee)

Updated

3 years ago
Assignee: nobody → doliver
Whiteboard: [priority]
(Assignee)

Comment 1

3 years ago
Created attachment 8436057 [details] [review]
master PR
Attachment #8436057 - Flags: review?(yor)
(Assignee)

Comment 2

3 years ago
Created attachment 8436084 [details]
phase2 PR
Attachment #8436084 - Flags: review?(yor)

Comment 3

3 years ago
Dylan,

I don't see "warning" strings defined for the other languages under locales dir.
The code looks good.
(Assignee)

Comment 4

3 years ago
Yes, most of the other localizations are out of date -- that's my next task but this will at least clear the path when they are ready.

Updated

3 years ago
Attachment #8436057 - Flags: review?(yor) → review+

Updated

3 years ago
Attachment #8436084 - Flags: review?(yor) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/notes/commit/9765440ba12f8705da1fb2934ab626fa5fdfadfa

The phase2 PR needs rebasing before it can be merged.
Keywords: checkin-needed
Target Milestone: --- → 2.0 S4 (20june)
(Assignee)

Comment 6

3 years ago
Created attachment 8436516 [details] [review]
updated phase2 PR

Fixed up PR, carried forward :yor's r+
Attachment #8436084 - Attachment is obsolete: true
Attachment #8436516 - Flags: review+
(Assignee)

Comment 7

3 years ago
Thanks Ryan, phase2 should be ready for merging now.
Keywords: checkin-needed
phase2: https://github.com/mozilla-b2g/notes/commit/58124da2611adbdb28e709aa450a2afbe92ed5d7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.