1021873 - rm_old_symbols step is failing for win64-ff64 nightlies

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jordan Lund (:jlund)]

not sure when it started failing or if it always had. looks like it could be a syntax error:

log example: https://pastebin.mozilla.org/5364463

build example: http://buildbot-master84.srv.releng.scl3.mozilla.com:8001/builders/WINNT%206.1%20x86-64%20mozilla-central%20nightly/builds/84

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: b1021873.diff

I think we should just remove this code, as it's a leftover from the old way of doing symbols. These days they are at
  <objdir>/dist/firefox-32.0a1.en-US.mac64.crashreporter-symbols-full.zip
  <objdir>/dist/firefox-32.0a1.en-US.mac64.crashreporter-symbols.zip
and something else handles cleaning up (probably just by using the same filename so they get replaced).

I also double checked the status db. So far this year we did 17745 rm_old_symbols steps, and every single one ended up with FAILURE result. This isn't completely watertight, given the example above
  find: missing argument to `-exec'
and the usual
  find: `20*': No such file or directory
both end up in the same state, but the fact we had not a single SUCCESS indicates to me we're never finding a file to delete. Besides we always clobber the nightly dir as the 2nd last step.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8436577 [details] [diff] [review]
b1021873.diff

https://hg.mozilla.org/build/buildbotcustom/rev/94ca5411a67f

Comment 3

[Simone Bruno [:simone]]

Live with reconfig on 2014-06-11 08:47 PT