102190 - Allow customization of Tooltip text for Animated Logo

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, defect)

Description

[bobj]

Currently CCK uses the customized URL for the Animated Logo as the tooltip text.

CCK should allow the tooltip text to be customized (e.g., "Go to Home page of
Acme Corporation").

Comment 1

[Shruti Vasudevan]

Reassigning bug to Shannon as per Tao's email.

Comment 2

[Barrett Lindstrom]

qa to blee

Comment 3

[Shannon Diener]

Attachment: Screen shot of added animated logo tooltip entry

Comment 4

[Shannon Diener]

Attachment: patch to add customization of animated logo tooltip

Comment 5

[Shannon Diener]

Attached a patch and a screen shot showing the addition of the animated logo
tooltip customization.

Comment 6

[Shruti Vasudevan]

What happens if the user leaves the text for animated logo blank, does a blank 
tooltip appear?  If a blank tooltip appears, we should think of introducing some 
error checking, like not to leave the text for tooltip blank.

Comment 7

[Shannon Diener]

Yes, if the user leaves the text for the animated logo blank the tooltip will be
blank.  Should this be something that the user is allowed to do?

I was also able to create a customized build without a logo url ... in this case
should the logo tooltip be blank?

Comment 8

[Rob Jaworski]

in for rtm per triage.

Comment 9

[Shannon Diener]

Attachment: screenshot of new field entry next to screen shot of original screen

Screenshot of this page with new tooltip field (on left) next to the original
screen (added for comparison, on right)

Comment 10

[Shannon Diener]

Attachment: Patch

Updated patch for new tooltip field

Comment 11

[Shannon Diener]

I've just attached a new screenshot and patch to add a field that would allow a
user to customize the tooltip.

In order to fit this field on the screen, I had to make the existing "Show
Example" and Edit box fields a bit shorter in height.  My screenshot attachment
shows a shot of the new screen on the left with the old screen to the right for
comparison.

cc'ing more people since this is a UI change.

Comment 12

[Rob Jaworski]

cckrtm+

Comment 13

[Shannon Diener]

Comment on attachment 85794 [details] [diff] [review]
Patch

Marking obsolete since these files have changed since I created this patch and
my cvs update failed to merge successfully

Comment 14

[Shannon Diener]

Attachment: updated patch to add tooltip field

This is the same patch as I had attached on 5/31, just updated to take into
account changes made to these files since I attached the last patch.

Still needs r= .... please :-)

Comment 15

[Shruti Vasudevan]

I agree that there is no consistency in the height of edit boxes in CCK tool.
But, all the edit boxes in the first 6 wizard pages atleast maintain a height
of either 14 or 15. This tooltip patch goes into the 4th page and the edit boxes
have a height of 12. The wizard screens may look a little inconsistent. As far
as possible, we need to maintain a height of 14. If this becomes too large to
fit into the screen, atleast we must maintain a height of 13. I hav'nt looked
into the height of text boxes, please make sure the height of text boxes is as
far as possible consistent with the other wizard pages.

Comment 16

[Shannon Diener]

Attachment: new screenshot of page with edit boxes of height 14

This screenshot shows the edit boxes and buttons with height of 14 instead of
12 as in the previous screenshot.

Comment 17

[Shannon Diener]

Attachment: updated patch keeping height 14

I was able to make room to keep edit box and button height to be 14.  The only
widget height changes were the AnimatedLogoURL edit box went from height 15 to
14 and the 2 Dynamic Text widgets (LargeAnimPath and LargeStillPath) went from
15 to 14.

Comment 18

[Shruti Vasudevan]

r=shrutiv
Please include the corresponding change for other customization tools.

Comment 19

[Shannon Diener]

patch checked in - resolved fixed

Comment 20

[blee]

Verified fixed in 6/24 bld.