1021942 - Transition away from using entity.textContent in Calendar L10n

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

In bug 994290, we're switching entity attributes to be DOM attributes instead of properties.

One of the blockers is the use of entity.textContent in Calendar app: https://github.com/mozilla-b2g/gaia/blob/ff9bdaaa0dd52fc544243e6c3d1bae3e8300747d/apps/calendar/locales/calendar.en-US.properties#L91-L94

sync-frequency-manual.textContent=Manually
sync-frequency-15min.textContent=15 min
sync-frequency-30min.textContent=30 min
sync-frequency-hourly.textContent=Each hour

One of them seems not to be used anywhere, others seem to be used here: https://github.com/mozilla-b2g/gaia/blob/ff9bdaaa0dd52fc544243e6c3d1bae3e8300747d/apps/calendar/elements/advanced_settings.html#L45-L47

Since during localization we take entity's value and put it as textContent of the node is seems to me that we should be just able to remove the obsolete one and switch the others to values:


sync-frequency-15min=15 min
sync-frequency-30min=30 min
sync-frequency-manual=Manually

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

James, you seem to be the original author of that code. Can you review my patch?

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 8436068 [details] [review]
patch

this looks fine to me but I am not very active in calendar right now... redirecting to Miller

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8436068 [details] [review]
patch

LGTM! simpler and still works as expected. thanks!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/915a107506b0079d03ae8cc69ceeb332a6ff968f
Merge: https://github.com/mozilla-b2g/gaia/commit/99f6cb35f8a1661d607b062fdb7c13528eee9bb0