1021945 - Don't create bug attachments for child requests, but do mirror reviews

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

When the hg review-repo hook creates review requests, it creates one parent review request containing a squashed diff of all commits to be reviewed and then one child review request for each commit.

Since the parent contains all the changes, it should be the only one to create an associated attachment in the bug--when it is r+ed, the patch in its entirety (all commits) are ready to be landed.  However, child requests should still have their reviews mirrored over, since reviewers might be focussing on individual commits.

Thus all requests should have the associated bug ID, and all reviews to all requests in the "family" should be mirrored to that bug, but any request with a parent should not post an attachment to the bug.

Comment 1

[(no longer active)]

George, are you interested in taking this?

Comment 2

[George Miroshnykov ( :gmiroshnykov )]

I believe Mark is already working on this in rbbz, not much I can do inside the hook.
But if there's something I can help with, please let me know!

Comment 3

[(no longer active)]

I see, sounds good!

Comment 4

[Mark Côté [:mcote]]

Yup, I'm going to handle this.  Should be pretty simple.

Comment 5

[Mark Côté [:mcote]]

I committed this (https://github.com/mozilla/rbbz/commit/4c5d78bfba1b6fd8018239f91ac26f75c397e494) but just realized I got it backwards.  The parent reviews, the ones we want created in Bugzilla, have the "depends on" field set, not the children.  It would be easy enough to switch, except it would break the work flow for anyone not using a review repo, since they wouldn't normally use depends on.  I'll have to think a bit about this.

Comment 6

[Mark Côté [:mcote]]

This was fixed in a different way in http://hg.mozilla.org/hgcustom/version-control-tools/rev/d9c4a5eef14e by checking if the review request is squashed or not.