Closed Bug 1022077 Opened 8 years ago Closed 8 years ago

WebGLVertexArrayFake::BindVertexArrayImpl() should disable other enabled vertex attributes >= WebGLVertexArrayFake::mAttributes.Length()

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: guillaume.abadie, Assigned: guillaume.abadie)

References

Details

Attachments

(1 file)

Currently, WebGLVertexArrayFake::BindVertexArrayImpl() is enabling/disabling vertex attributes in the rang [0 .. mAttributes.Length()[, but it also should disable all other vertex attributes >= mAttributes.Length() enabled by the previously bound vertex array object.

http://dxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLVertexArrayFake.cpp?from=WebGLVertexArrayFake.cpp&case=true#37

Found while browsing at the code. Fixing...
Never mind, can't fix, because of build failures.
Attached patch fix - revision 1Splinter Review
This patch has been tested on WebGL conformance tests 1.0.3 by forcing the utilisation of the software implementation of vertex array object in WebGLVertexArray::Create().

Push to try:
https://tbpl.mozilla.org/?tree=Try&rev=a6134152fbd3
Attachment #8436412 - Flags: review?(jgilbert)
Assignee: nobody → guillaume.abadie
Attachment #8436412 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/1fcdf06b3224
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.