Closed
Bug 1022077
Opened 11 years ago
Closed 11 years ago
WebGLVertexArrayFake::BindVertexArrayImpl() should disable other enabled vertex attributes >= WebGLVertexArrayFake::mAttributes.Length()
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
Details
Attachments
(1 file)
|
5.75 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Currently, WebGLVertexArrayFake::BindVertexArrayImpl() is enabling/disabling vertex attributes in the rang [0 .. mAttributes.Length()[, but it also should disable all other vertex attributes >= mAttributes.Length() enabled by the previously bound vertex array object.
http://dxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLVertexArrayFake.cpp?from=WebGLVertexArrayFake.cpp&case=true#37
Found while browsing at the code. Fixing...
|
Assignee | |
Comment 1•11 years ago
|
||
Never mind, can't fix, because of build failures.
|
|
Assignee | |
Comment 2•11 years ago
|
||
This patch has been tested on WebGL conformance tests 1.0.3 by forcing the utilisation of the software implementation of vertex array object in WebGLVertexArray::Create().
Push to try:
https://tbpl.mozilla.org/?tree=Try&rev=a6134152fbd3
Attachment #8436412 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → guillaume.abadie
|
||
Updated•11 years ago
|
Attachment #8436412 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•