1022134 - [Camera] Remove snap back rotation in AF indicator animation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

Hi, 

Now that we have the CF and AF, I think we should remove the snap back rotation in the AF animation. It doesn't run smoothly on the Flame and it seems too different from the CF animation with the snap back.

Thanks

Comment 1

[Amy Lee [:amylee] UX]

Just reviewed master and it looks like the AF indicator animation has changed so there is no rotation at all. We should have the rotation put back in the AF indicator so it rotates 45 degrees and turns green when you hit image capture.

Comment 2

[Diego Marcos [:dmarcos]]

What device are you using?

continuous auto focus and touch to focus don't focus on image capture. The former focuses automatically and the latter when the user taps the screen. The goal is that taking an image happens very quick so you don't miss the moment. This is how all cameras work. 

Green means that the camera has focused in the object and red that focus has failed. Showing green at capture time is misleading. 

Also rotation seems to be a source of choppiness in the animation. No rotation also makes user feedback consistent for continuous auto focus and touch to focus. The focus ring color is missing on continuous auto focus but there's a separate keeping track of it (bug 1022880)

Comment 3

[Amy Lee [:amylee] UX]

(In reply to Diego Marcos [:dmarcos] from comment #2)
> What device are you using?
> 
> continuous auto focus and touch to focus don't focus on image capture. The
> former focuses automatically and the latter when the user taps the screen.
> The goal is that taking an image happens very quick so you don't miss the
> moment. This is how all cameras work. 
> 
> Green means that the camera has focused in the object and red that focus has
> failed. Showing green at capture time is misleading. 
> 
> Also rotation seems to be a source of choppiness in the animation. No
> rotation also makes user feedback consistent for continuous auto focus and
> touch to focus. The focus ring color is missing on continuous auto focus but
> there's a separate keeping track of it (bug 1022880)

Hi, 

I'm using the flame device. If possible, I would have the rotation happen on both AF and CF but without the snap back. So it rotates 45 degrees and turns green in both instances when focused. When taking a photo, I am still seeing the spinner show up every time I capture an image, I know this has been brought up before so I'm not sure if it has been fixed yet.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Hi Amy, any update on this? On a recent flame build, it looks like the "snapback" is gone.

Comment 5

[Amy Lee [:amylee] UX]

Attachment: edited-focus-ring.css

Hi, 

Can you please replace focus-ring.css with this version? I've edited the focus ring animation so there is no snap-back rotation and added a new keyframe animation.

Thanks!

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1022134 > mozilla-b2g:master

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8649905 [details] [review]
[gaia] wilsonpage:1022134 > mozilla-b2g:master

FYI: I submitted this PR on behalf of :amylee, I'm not r+ing myself :)

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8649905 [details] [review]
[gaia] wilsonpage:1022134 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/d79f22011421595a0f5618845cf00f02750e820c