1022208 - Greasemonkey stops working in Nightly32.0a1

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[Alice0775 White]

Attachment: GM_xmlhttpRequest.user.js

Steps To Reproduce:
1. Install Greasemonkey1.15 https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/
2. Install attached userscript (for example)
3. Open any web page

Actual Results:
An error shown in Error console

Error: Greasemonkey access violation: unsafeWindow cannot call GM_xmlhttpRequest. (Xray)

Expected Results:
No error.
An alert box should appears.

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b92083bb0e8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140605223056
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8501686e4923
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140605223356
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5b92083bb0e8&tochange=8501686e4923

Suspected: Bug 987111

Comment 1

[Alice0775 White]

Greasemonkey latest 2.0beta1( https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/ ) is also affected.

Comment 2

[Anthony Lieuallen]

This clearly has something to do with the way we do stack introspection to attempt to avoid leaks (of privileged functions to content scopes).

Comment 3

[Bobby Holley (:bholley)]

Ok. I'm assuming that GreaseMonkey is going to need to be updated here unless Anthony tells me otherwise. Flagging him for the investigation.

Comment 4

[makondo]

I'm using Fx31b2 and GM 2.0 - all my installed scripts quit working. So, beta 2 is effected as well (it was all working fine in Fx31b1).

Comment 5

[Anthony Lieuallen]

Ah!  I just noticed the "(Xray)" on the end of the error message; that's significant!  Either way the correct solution is just to remove this leak check; switching to expanded principals (which we just did in GM 2.0) is the right way to accomplish this, so this check is superfluous now.

https://github.com/greasemonkey/greasemonkey/commit/7031a322ee537accabe058136efa3084d448bac5

Should fix this.  Try the next GM nightly:

https://arantius.com/misc/gm-nightly/

(after 2014.06.18) which should contain only this change, to confirm.

Comment 6

[Alice0775 White]

Gresemonkey 2.1beta1 fixes the problem.