102224 - Modern skin uses incorrect system fonts

Status: RESOLVED EXPIRED

(SeaMonkey :: Themes, defect)

Description

[Simon Fraser [no longer active]]

Modern skin looks bad on Mac for a number of reasons:
1. The font uses in popup menus is very large.
2. The font used in dialog buttons is very large.

Unfortunately, I can't change one of these without affecting the other, because 
both 'menuitem' and 'button' use "font: menu", which just seems plain wrong.

I think we need a better designation of system fonts. Specifically, to get good-
looking Mac UI, we need separate font specifiers for:

1. menus and menulists (should map to small system font). Since Mac users native
   top-level menus, we never use these styles for the main menus, only for popups
   like context menus, the bookmarks popup, and popups in dialogs.

   Ideally, we should have independent specifiers for top-level, and popup menus
   so that we can distinguish these.

2. Tabs in the tab widget (should map to small emphasised system font).

3. Main buttons in dialogs (by "main" I mean the OK/Cancel/Help buttons; those in
   the bottom row). These should map to the system font.

4. Subsidiary buttons in dialogs. Buttons that are not the main buttons normally
   user a smaller font, which is ususally the same as the font used for captions,
   popup menus etc. It maybe the small system font, or the small emphasised
   system font.

Why don't we make use of all the system font designations here:?

http://lxr.mozilla.org/seamonkey/source/layout/base/public/nsStyleConsts.h#374

Comment 1

[Simon Fraser [no longer active]]

Attachment: How modern should look on the Mac

Comment 2

[Simon Fraser [no longer active]]

Looking at the modern CSS, it becomes apparent that we've chosen system fonts in 
the CSS because of what they look like, rather than what they mean. Lots of 
widgets use "font: menu", which is just plain wrong.

Comment 3

[Simon Fraser [no longer active]]

Attachment: userChrome.css that makes modern look better on Mac

Comment 4

[Joe Hewitt (gone)]

giving to Shuehan

Comment 5

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 6

[Jo Hermans]

Is this still relevant under Mac OS X ?

Comment 7

[Andrew Thompson]

Yeah, it is. In the sense that the problems with fonts and sizes Simon's
correcting still exist on OS X. If you compare the fonts used in a dialog in any
Aqua app to those used in the Modern skin they're still obviously wrong.

I'm not sure what the fix should be thought:

(i) Doesn't Firebird use a new theme anyway?
(ii) If we change the fonts in the modern skin, it'll effect all platforms and
will need to be ok'd everywhere?
(iii) Or is there some way to do Mac specific overlays? I don't think
userChrome.css is the "real" solution...

Comment 8

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 9

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420