1022272 - WebGL bug: calling drawArrays() with a divisor different than 0 for all attributes should be illegal with ANGLE_instanced_arrays

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Guillaume Abadie]

Since drawArray(mode, first, count) == DrawArraysInstanced(mode, first, count, 1),
WebGLContext::DrawArrays(...) should also verify DrawInstanced_check("drawArraysInstanced") == true.

http://hg.mozilla.org/mozilla-central/annotate/7146e89a7b83/content/canvas/src/WebGLContextDraw.cpp#l149

Same for WebGLContext::DrawElements().

Comment 1

[Guillaume Abadie]

Attachment: bug_1022272.patch

This patch just move the WebGLContext::DrawInstanced_check() verification within WebGLContext::Draw{Arrays,Elements}_check() in order to have WebGLContext::Draw{Arrays,Elements}(Instanced) verifying it automatically.

Push to try:
https://tbpl.mozilla.org/?tree=Try&rev=9fa6b9c9476d

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8436427 [details] [diff] [review]
bug_1022272.patch

Review of attachment 8436427 [details] [diff] [review]:
-----------------------------------------------------------------

Nits, but functionally correct.

::: content/canvas/src/WebGLContextDraw.cpp
@@ +111,5 @@
>      if (!DoFakeVertexAttrib0(checked_firstPlusCount.value())) {
>          return false;
>      }
> +
> +    if (!DrawInstanced_check("drawElementsInstanced")) {

s/"drawElementsInstanced"/info/

@@ +284,5 @@
>      if (!DoFakeVertexAttrib0(mMaxFetchedVertices)) {
>          return false;
>      }
> +
> +    if (!DrawInstanced_check("drawElementsInstanced")) {

s/"drawElementsInstanced"/info/

Comment 3

[Guillaume Abadie]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae206ecb6f57

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ae206ecb6f57