Closed Bug 1022383 Opened 6 years ago Closed 6 years ago

[Collection App] Should show four columns instead of three

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe],)

Attachments

(2 files)

Also possibly include some refactoring of the API to change columns.
Attached file Github pull request
I would like to write a test or two, but this is nearly done.
Comment on attachment 8436531 [details] [review]
Github pull request

This changes the interfaces for setting the number of columns in gaia grid to be an attribute of the grid. There is a lack of tests for this, but in the next week or two I plan on landing a test components app which we will have deep integration testing for.

Looking for a review here - whoever gets to it first, thanks!
Attachment #8436531 - Flags: review?(ran)
Attachment #8436531 - Flags: review?(dale)
Attachment #8436531 - Flags: review?(amirn)
Put in a few comments on GH
Comment on attachment 8436531 [details] [review]
Github pull request

added comments on Github.

Also,
1. found it harder to pinch/zoom than usual - keeps triggering edit mode. Not sure if this is a regression.

2. question - will it be easy to add zoom="true" attribute as well? (in case UX decides Collections should also support that)
feature-b2g: --- → 2.0
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Comment on attachment 8436531 [details] [review]
Github pull request

I was able to reproduce the pinch-zoom bug on master so will file a new bug for it.
Attachment #8436531 - Flags: review?(ran)
Attachment #8436531 - Flags: review?(dale)
Attachment #8436531 - Flags: review?(amirn)
Attachment #8436531 - Flags: review+
Adding NO_UPLIFT to preserve landing order with approvals instead.
Whiteboard: [p=2],[systemsfe] → [p=2],[systemsfe],[NO_UPLIFT]
Landed: https://github.com/mozilla-b2g/gaia/commit/0cfb7dd23d0882a1235a384153b05e5397098a17
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8436531 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8436531 - Flags: approval-gaia-v2.0?(bbajaj)
Comment on attachment 8436531 [details] [review]
Github pull request

Might be good to check the gaia UI tests once this lands to ensure the landings clean and green as expected!
Attachment #8436531 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Whiteboard: [p=2],[systemsfe],[NO_UPLIFT] → [p=2],[systemsfe],
Attached video Verify_Video_Flame.MP4
This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.