1022383 - [Collection App] Should show four columns instead of three

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Kevin Grandon :kgrandon]

Also possibly include some refactoring of the API to change columns.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

I would like to write a test or two, but this is nearly done.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8436531 [details] [review]
Github pull request

This changes the interfaces for setting the number of columns in gaia grid to be an attribute of the grid. There is a lack of tests for this, but in the next week or two I plan on landing a test components app which we will have deep integration testing for.

Looking for a review here - whoever gets to it first, thanks!

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Put in a few comments on GH

Comment 4

[Amir Nissim (:amirn)]

Comment on attachment 8436531 [details] [review]
Github pull request

added comments on Github.

Also,
1. found it harder to pinch/zoom than usual - keeps triggering edit mode. Not sure if this is a regression.

2. question - will it be easy to add zoom="true" attribute as well? (in case UX decides Collections should also support that)

Comment 5

[Amir Nissim (:amirn)]

Comment on attachment 8436531 [details] [review]
Github pull request

I was able to reproduce the pinch-zoom bug on master so will file a new bug for it.

Comment 6

[Kevin Grandon :kgrandon]

Adding NO_UPLIFT to preserve landing order with approvals instead.

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/0cfb7dd23d0882a1235a384153b05e5397098a17

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8436531 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 8436531 [details] [review]
Github pull request

Might be good to check the gaia UI tests once this lands to ensure the landings clean and green as expected!

Comment 10

[Kevin Grandon :kgrandon]

Thanks, tests look good. Uplifted: https://github.com/mozilla-b2g/gaia/commit/b3681422e4eed4855f533a2e527b60f4282a2807

Comment 11

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0