Closed
Bug 1022390
Opened 11 years ago
Closed 11 years ago
[Vertical] Cancel download of apps
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)
Tracking
(feature-b2g:2.0, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: jlal, Assigned: crdlc)
References
Details
(Keywords: late-l10n, Whiteboard: [p=2],[systemsfe])
Attachments
(5 files)
115.38 KB,
image/png
|
pla
:
ui-review+
|
Details |
115.04 KB,
image/png
|
pla
:
ui-review-
|
Details |
190 bytes,
text/html
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details |
596.36 KB,
application/pdf
|
Details | |
117.44 KB,
application/zip
|
Details |
The old homescreen would let you cancel ongoing downloads we should probably too.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8436900 -
Flags: ui-review?(pla)
Assignee | ||
Comment 2•11 years ago
|
||
I think that the action is blue instead of red but when you will give me the feedback I address it, many thanks
Attachment #8436901 -
Flags: ui-review?(pla)
Assignee | ||
Comment 3•11 years ago
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking+]
Updated•11 years ago
|
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
Comment 4•11 years ago
|
||
Cristain - For the Restart Download, I believe instead of the button saying "Resume" it should say "Download" if the download is starting from the beginning. If not, the title for that one should be changed.
As you mentioned as well, the button should be blue not red for the restart download.
Comment on attachment 8436900 [details]
Stop download in progress
Looks good!
Attachment #8436900 -
Flags: ui-review?(pla) → ui-review+
Comment on attachment 8436901 [details]
Restart download
This button should be blue and say 'Download', as Jacqueline mentioned in her comment.
Attachment #8436901 -
Flags: ui-review?(pla) → ui-review-
Assignee | ||
Comment 7•11 years ago
|
||
ok, I gonna finish it today mates, at least I hope so XD
Assignee | ||
Updated•11 years ago
|
Attachment #8436948 -
Flags: review?(kgrandon)
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking+][VH-FC-blocking+]
Comment 8•11 years ago
|
||
Taking a look at this now. I'm having a hard time actually doing this on a device. It would be really good to write a marionette test for this stuff, but I understand it may be slightly tricky.
User Story: (updated)
Comment 9•11 years ago
|
||
Comment on attachment 8436948 [details]
Github pull request
I left a few nits about event names on github, but overall this looks really good. Please either address the event name nits, or state your argument and you can land after doing either of those :) Thanks for the patch!
Attachment #8436948 -
Flags: review?(kgrandon) → review+
Comment 10•11 years ago
|
||
Attaching spec that includes the app installation states in a bit more detail. Let me know if there are any questions.
Assignee | ||
Comment 11•11 years ago
|
||
This bug is to cancel and resume downloads, please file a new bug regarding to "App Download Fails"
(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
>
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.
Assignee | ||
Comment 12•11 years ago
|
||
I agree with you so I addressed all comments
(In reply to Kevin Grandon :kgrandon from comment #9)
> Comment on attachment 8436948 [details]
> Github pull request
>
> I left a few nits about event names on github, but overall this looks really
> good. Please either address the event name nits, or state your argument and
> you can land after doing either of those :) Thanks for the patch!
Assignee | ||
Comment 13•11 years ago
|
||
Peter, according to this spec we need a new image to indicate what an app failed downloading, could you assign it to somebody? Many thanks
(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
>
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.
Comment 15•11 years ago
|
||
Hi Cristian,
Yes, I have 2 sets of graphics ready, but I'm waiting for approval of our first choice from the brand team. I've asked them to reply by early/mid-day today. If it takes any longer, we'll go with the second choice and I will attach the image assets to all the relevant bugs (3 of them I believe).
Stay tuned.
Flags: needinfo?(pla)
Assignee | ||
Comment 16•11 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/2ec8e0628192868d5bbe9fc964d45321ea6ea62a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 17•11 years ago
|
||
Cancel feature checked. Waiting for the new icon to mark this bug as verified.
Reporter | ||
Comment 18•11 years ago
|
||
The visual work will happen here https://bugzilla.mozilla.org/show_bug.cgi?id=1023950
Comment 20•11 years ago
|
||
Comment on attachment 8436948 [details]
Github pull request
This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8436948 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•11 years ago
|
Attachment #8436948 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 21•11 years ago
|
||
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
Comment 22•11 years ago
|
||
Updated•10 years ago
|
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
blocking-b2g: 2.0? → ---
Updated•10 years ago
|
Flags: in-moztrap?(jlorenzo)
Updated•9 years ago
|
Flags: in-moztrap?(jlorenzo)
You need to log in
before you can comment on or make changes to this bug.
Description
•