If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Vertical] Cancel download of apps

VERIFIED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
P2
normal
VERIFIED FIXED
3 years ago
a year ago

People

(Reporter: lightsofapollo, Assigned: crdlc)

Tracking

({late-l10n})

unspecified
2.0 S4 (20june)
x86
Mac OS X
late-l10n

Firefox Tracking Flags

(feature-b2g:2.0, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(5 attachments)

(Reporter)

Description

3 years ago
The old homescreen would let you cancel ongoing downloads we should probably too.
(Assignee)

Updated

3 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8436900 [details]
Stop download in progress
Attachment #8436900 - Flags: ui-review?(pla)
(Assignee)

Comment 2

3 years ago
Created attachment 8436901 [details]
Restart download

I think that the action is blue instead of red but when you will give me the feedback I address it, many thanks
Attachment #8436901 - Flags: ui-review?(pla)
(Assignee)

Comment 3

3 years ago
Created attachment 8436948 [details]
Github pull request
QA Whiteboard: [VH-FL-blocking+]
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
Cristain - For the Restart Download, I believe instead of the button saying "Resume" it should say "Download" if the download is starting from the beginning. If not, the title for that one should be changed. 

As you mentioned as well, the button should be blue not red for the restart download.

Comment 5

3 years ago
Comment on attachment 8436900 [details]
Stop download in progress

Looks good!
Attachment #8436900 - Flags: ui-review?(pla) → ui-review+

Comment 6

3 years ago
Comment on attachment 8436901 [details]
Restart download

This button should be blue and say 'Download', as Jacqueline mentioned in her comment.
Attachment #8436901 - Flags: ui-review?(pla) → ui-review-
(Assignee)

Comment 7

3 years ago
ok, I gonna finish it today mates, at least I hope so XD
(Assignee)

Updated

3 years ago
Attachment #8436948 - Flags: review?(kgrandon)
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking+][VH-FC-blocking+]
Keywords: late-l10n
Taking a look at this now. I'm having a hard time actually doing this on a device. It would be really good to write a marionette test for this stuff, but I understand it may be slightly tricky.
User Story: (updated)
Comment on attachment 8436948 [details]
Github pull request

I left a few nits about event names on github, but overall this looks really good. Please either address the event name nits, or state your argument and you can land after doing either of those :) Thanks for the patch!
Attachment #8436948 - Flags: review?(kgrandon) → review+
Created attachment 8438099 [details]
App Download June10.pdf

Attaching spec that includes the app installation states in a bit more detail. Let me know if there are any questions.
(Assignee)

Comment 11

3 years ago
This bug is to cancel and resume downloads, please file a new bug regarding to "App Download Fails"

(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
> 
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.
(Assignee)

Comment 12

3 years ago
I agree with you so I addressed all comments

(In reply to Kevin Grandon :kgrandon from comment #9)
> Comment on attachment 8436948 [details]
> Github pull request
> 
> I left a few nits about event names on github, but overall this looks really
> good. Please either address the event name nits, or state your argument and
> you can land after doing either of those :) Thanks for the patch!
(Assignee)

Comment 13

3 years ago
Peter, according to this spec we need a new image to indicate what an app failed downloading, could you assign it to somebody? Many thanks

(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
> 
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.
(Assignee)

Comment 14

3 years ago
comment 13 :)
Flags: needinfo?(pla)

Comment 15

3 years ago
Hi Cristian,

Yes, I have 2 sets of graphics ready, but I'm waiting for approval of our first choice from the brand team.  I've asked them to reply by early/mid-day today.  If it takes any longer, we'll go with the second choice and I will attach the image assets to all the relevant bugs (3 of them I believe).

Stay tuned.
Flags: needinfo?(pla)
(Assignee)

Comment 16

3 years ago
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/2ec8e0628192868d5bbe9fc964d45321ea6ea62a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Cancel feature checked. Waiting for the new icon to mark this bug as verified.
(Reporter)

Comment 18

3 years ago
The visual work will happen here https://bugzilla.mozilla.org/show_bug.cgi?id=1023950
It's verified then ;)
Status: RESOLVED → VERIFIED
Comment on attachment 8436948 [details]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8436948 - Flags: approval-gaia-v2.0?(bbajaj)

Updated

3 years ago
Attachment #8436948 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Uplifted: https://github.com/mozilla-b2g/gaia/commit/7760cb0b064490fc84b9053f3d83ac4c637b6b58
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed

Comment 22

3 years ago
Created attachment 8438828 [details]
AppInstallVisualAssets.zip

Updated

3 years ago
blocking-b2g: --- → 2.0?

Updated

3 years ago
blocking-b2g: 2.0? → ---
Flags: in-moztrap?(jlorenzo)
Flags: in-moztrap?(jlorenzo)
You need to log in before you can comment on or make changes to this bug.