Closed Bug 1022472 Opened 6 years ago Closed 6 years ago

Remove margins on default home screen panels

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 --- ?
firefox35 --- fixed
fennec 35+ ---

People

(Reporter: wesj, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Our built in panels have margins on the left and right on tablets. The new hub panels don't. It makes lists look kinda silly. We should use the same style we use for our built in panels.
Blocks: lists
Component: General → Awesomescreen
Flags: needinfo?(alam)
Hey guys, I noticed this too and have it in my head but I'm going to have to push forward with some other bugs before I can get to this. I'm also going to leave the NI on for that purpose :)
Our default panels should definitely not have those margins left and right (looking at the History panel on a N7 vert.).

I'd love to do a design pass at these panels altogether. After I get to work on this Sync Panel for Nick in Bug 1014994, I would probably have a better framework for scaling these panels across mobile and tablets.

Maybe we can start by extending those to the ends like our newer panels?
Flags: needinfo?(alam)
OS: Linux → Android
Hardware: x86_64 → All
Summary: Hub panels take up full screen width on tablets → Tablet: remove margins on default home screen panels
Version: unspecified → Trunk
Duplicate of this bug: 1065125
Summary: Tablet: remove margins on default home screen panels → Remove margins on default home screen panels
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
As far as I can tell this bug only applies to History.

Tested this on modern phone, and small and large tablets.

ckitching: could you test this on your S2?
Attachment #8486817 - Flags: review?(wjohnston)
This fixes it for me.
This is probably more fallout from bug 1004850 (similar to bug 1062632).

So hopefully that means this isn't a problem on release, although wesj filed this bug before bug 1004850 landed...
I just saw margins appears on my recent tabs panel on a phone on Nightly (but not on Aurora). Have there been other recent changes here that could have affected this? Maybe my patch for bug 1062632 did something I didn't expect?

In any case, I just tested this patch and confirmed it fixes that problem for me. So +1 :)

(We should probably rename the home_history_list layout, since it's also used in the recent tabs panel, I'll file a separate bug.)
(In reply to :Margaret Leibovic from comment #7)
> Have there been other recent changes here that could
> have affected this?

Yeah, Bug 1044334. We were deep in undefined behavior land before, so this bug is about making sure the real behavior is what we want :)
Comment on attachment 8486817 [details] [diff] [review]
Remove margins on default home screen panels. v1

Review of attachment 8486817 [details] [diff] [review]:
-----------------------------------------------------------------

This makes history no longer match other panels when in landscape on xlarge devices, for example bookmarks [1]. Do we want to remove the padding on other panels as well? Do we want to keep the margins for this history panel on large tablets? It feels silly to me having it stretch edge to edge (which is why I originally filed this bug, although its been re-purposed since then).

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values-large-land-v11/styles.xml#27
Discussed on IRC: prior to nailing bug 1063058, we'll just kill padding on bookmarks and history.

Will post updated patch and screenshots.
This:

* Lifts stuff out of the bookmark list styles into Top Sites where appropriate to match inheritance lookups.
* Removes padding for the bookmarks and history styles.
* Ensures that the history panel has a top divider line.

Verifies that appearance matches Nightly-with-expected-changes. Verified that visual jank during port/land rotation is no worse than Nightly.

Verified on xlarge-v11; gonna test on phone now.
Attachment #8488927 - Flags: review?(wjohnston)
Attachment #8486817 - Attachment is obsolete: true
Attachment #8486817 - Flags: review?(wjohnston)
Recent regression
tracking-fennec: --- → ?
Keywords: regression
Comment on attachment 8488927 [details] [diff] [review]
Remove margins on default home screen panels. v2

Review of attachment 8488927 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8488927 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/e016c34c4d52
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
wat
Tested locally on Nexus 10. Presumably the forced top divider that we removed counts as a view. Unexpected perf improvement, too!
Attachment #8489775 - Flags: review?(mark.finkle)
Attachment #8489775 - Flags: review?(mark.finkle) → review+
(In reply to Wes Kocher (:KWierso) from comment #17)
> https://hg.mozilla.org/mozilla-central/rev/e016c34c4d52

This got merged to m-c minus the backout. Sorry for the confusion.
Status: RESOLVED → REOPENED
Flags: needinfo?(kwierso)
Resolution: FIXED → ---
Target Milestone: Firefox 35 → ---
Sorry, didn't notice the permafail when I did the merge.
Flags: needinfo?(kwierso)
https://hg.mozilla.org/mozilla-central/rev/de389f79f43e
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
tracking-fennec: ? → 35+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.