1022480 - permission-request screen has a bonus message about "Select a camera" (but with no ability to do so, or reason for doing so)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:
 1. Launch any app that requires geolocation. (for the first time, so that you get a prompt).  E.g. "Here Maps", or camera, or the "Geoloc" testing app

 2. Look at the bottom of the permission prompt.

ACTUAL RESULTS: Below the information about the geolocation permission request, there's an additional message that says:
> Select a camera for Geoloc
(or whatever the app's name is -- in my case, I'm using Geoloc)

EXPECTED RESULTS: No message about a camera (since this is purely a geolocation prompt).

I've hit this with the e.me search bar, the "camera" app, Here maps, and the "Geoloc" test app, all today.



Device/Version info:
I'm using a Flame device, running a locally-built version of B2G trunk.
OS Version: 2.0.0.0-prerelease
Git commit info: 2014-06-08 87a937c5

Adding 'regression' keyword, since I can't reproduce this in older Gaia versions. (e.g. I can't reproduce using whatever gaia version comes with the Simulator version of Firefox OS 2.0 -- it looks like that's using a pre-visual-refresh version of Gaia, or something.

Comment 1

[Jason Smith [:jsmith]]

Saw this as well. I think this is likely a regression from bug 938467.

Noming because is irrelevant UX showing up on a prompt that shows up all over the OS.

Fred - Can you take a look?

Comment 2

[[e-mail]]

looks like a regression to pass TBPL.

Comment 3

[Eric Chang [:ericcc] [:echang]]

Buri has no front camera, the text looks weird.
https://bug1021876.bugzilla.mozilla.org/attachment.cgi?id=8436790

Comment 4

[Eric Chang [:ericcc] [:echang]]

Attachment: AppPermissionSearchResults.png

Search results also has this weird message.

Comment 5

[[e-mail]]

Attachment: pull request redirect to github

In origin patch I reverted the global .hidden style to prevent pollute other system styles but missed to add this specific .hidden style.

Comment 6

[[e-mail]]

It's not only occurred in geolocation, but all permission dialogs

Comment 8

[Tiffanie Shakespeare [:tif]]

Patch looks good! Thanks guys! 
(Designer for Camera)

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Not sure ft:loop means since Fred of my team is working on this.

Changing component because this is a permission dialog bug.

Comment 10

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/27089faa5fbe8dea6768f5d45187a2f5b4ce9bc5

thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/669e099fded2244c264f204036f469d20cebcd8c

Comment 12

[Lancy(Leave from Mozilla)]

Attachment: Verify_1022480_flame_1.png

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_1022480_flame_1.png & Verify_1022480_flame_2.png
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0

Comment 13

[Lancy(Leave from Mozilla)]

Attachment: Verify_1022480_flame_2.png