1022488 - Searching the last used search term doesn't return search results

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Jason Smith [:jsmith]]

Build

* Device: Flame
* Version: 2.0 - b2g-inbound
* Build ID: 20140608173002
* Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
* Gecko: 7f3f35b511f8

STR

1. Open rocketbar search
2. Type "google" & hit return
3. Select close
4. Open rocketbar search again
5. Hit return

Expected

e.me search results should populate for google.

Actual

No e.me search results appear.

Additional Notes

This also reproduces if the search engine changes to any browser-related search engine (e.g. Yahoo, Bing).

Comment 1

[James Lal [:lightsofapollo]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20327

This does need a test... Should I r/f you or alive in the future for these rocketbar bugs?

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8438080 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20327

I'm not sure. I've reviewed a lot of rocketbar.js changes, so something simple like this is probably fine. Feel free to ask me later - I feel fine doing it.

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 8438080 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20327

now with test

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8438080 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20327

There are still some issues with text visibility, but we will handle those in a different bug. Thanks!

Comment 5

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/1475a6d8395829addb6b1ee4ef82fbbac637b7c9

Comment 6

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/f50ff2c5b897bb5f8def58b5611915a66d2011f8

Comment 7

[Johan Lorenzo [:jlorenzo]]

Verified on master.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1) Shouldn't the e.me search remain when tapping into the search bar, if they hit home?
2) If user taps the Close, return to HOMESCREEN and revert search app to Empty state.

Verified STR fixed in 2.0: 
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/164b61458ca5
BuildID   20140619000200
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014