1022512 - [B2G][Clock] Tap an existing alarm, the text on delete button does not horizontally center aligned.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect, P3)

Description

[Edward Chen[:edchen]]

Attachment: Screenshot

This is a visual refresh issue.

[Environment]
Gaia      2e5636e852a9354a5f8072b179cf16f72647cfd6
Gecko     https://hg.mozilla.org/mozilla-central/rev/8bd92dc9ef59
BuildID   20140608160201
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[STR]
1. Launch clock app
2. Create a alarm
3. Tap an existing alarm
4. See the delete button

[Actual result]
The text on delete button does not horizontally center aligned.

[Expected result]
The text on delete button must be horizontally center aligned.

[Attachment]
screenshot

Comment 1

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20629

Comment 2

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8441532 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20629

small CSS change, no risk.

Comment 3

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/736d63925739d3465da6934bd77a4cafbe8b52f5

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8441532 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20629

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

Trivial CSS fix, for 2.0 visual redesign. No risk.

[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 5

[bhavana bajaj [:bajaj]]

We will go the approval route here..

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 8441532 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20629

low risk polish change, approving for uplift.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/9900f2df07d0d5c239b2c8c5433623c0ab29547b

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e
BuildID   20140618160200
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 9

[Paladin]

Attachment: Verify_image.png

This issue has been verified successfully on Flame 2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
Flame 2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0