1022519 - [B2G][Calendar] wrong refresh button size

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[Edward Chen[:edchen]]

Attachment: Screenshot

[Environment]
Gaia      2e5636e852a9354a5f8072b179cf16f72647cfd6
Gecko     https://hg.mozilla.org/mozilla-central/rev/8bd92dc9ef59
BuildID   20140608160201
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[STR]
1. Launch calendar app
2. Add a new account
3. See the refresh icon

[Actual result]
The refresh button is wrong size, it seems a bit bigger.

[Expected result]
Please check spec and adjust to right size

[Attachment]
Screenshot

Comment 1

[Dylan Oliver [:doliver]]

blocking -- bug in new feature (vis refresh)

Comment 2

[James Burke [:jrburke]]

Attachment: GitHub pull request

Fixes by adding background-size, to match what is done for the settings button.

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8441590 [details] [review]
GitHub pull request

thanks!

Comment 4

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/b58c6d299a803db61c1beb4e0a17fc43fb09af6d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/20631

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/ad1a84926bf9876b75c54d9bbc90150852427f5e

Comment 7

[Edward Chen[:edchen]]

[Environment]
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e
BuildID   20140618160200
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 8

[Lancy(Leave from Mozilla)]

Attachment: Verify_1022519_Flame.png

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_1022519_Flame.png
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0