1022619 - The findbar doesn't show anything for the "not found" case

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Florian Quèze [:florian]]

I think the textbox used to be colored in red and there used to be a "not found" message after the "Match Case" button.

Comment 1

[aleth [:aleth]]

Attachment: findbar.diff

This was due to an old hack that no longer works.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8492269 [details] [diff] [review]
findbar.diff

Review of attachment 8492269 [details] [diff] [review]:
-----------------------------------------------------------------

r+ because I can see why your patch would work and the code is cleaner after it, but I would still be interested in understanding what happened here to cause the regression (that I noticed only a few months ago).

The only thing I find in the hg history that could explain this regression is revision 9ca5948baa2d:
 Bug 567306 - Only set the Find bar's browser property if its browser ID is valid.
where there is this change in the <findbar> constructor that seems like it breaks our existing hack:
-        setTimeout(function(aSelf) { aSelf.browser = aSelf.browser; }, 0, this);
+        if (this.getAttribute("browserid"))
+          setTimeout(function(aSelf) { aSelf.browser = aSelf.browser; }, 0, this);

Do we really think we've had this regression since a patch from 2011?

Comment 3

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Do we really think we've had this regression since a patch from 2011?

I was wondering the same thing - it seems unlikely, even if it is true that the findbar was probably rarely used as searching only the current conversation is fairly useless. On the other hand I can't remember exactly what a failed search looked like in IB before the recent findbar redesign...

Comment 4

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #3)
> (In reply to Florian Quèze [:florian] [:flo] from comment #2)
> > Do we really think we've had this regression since a patch from 2011?
> 
> I was wondering the same thing - it seems unlikely, even if it is true that
> the findbar was probably rarely used as searching only the current
> conversation is fairly useless.

I use it frequently, definitely several times per week, but probably almost only when I'm sure a word was there (eg. if my nick was mentioned and I want to jump to the mention, or if I want to see what the first message from a nick who's currently talking was, ...).

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/82f288fa2c38