Closed Bug 1022624 Opened 5 years ago Closed 5 years ago

Implement support for gradients with ExtendMode::REFLECT in DrawTargetCG

Categories

(Core :: Graphics, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(3 files)

Attached patch linear gradientsSplinter Review
No description provided.
Attachment #8436903 - Flags: review?(jmuizelaar)
Attached patch radial gradientsSplinter Review
Attachment #8436904 - Flags: review?(jmuizelaar)
Attached patch share more codeSplinter Review
Attachment #8436906 - Flags: review?(jmuizelaar)
I should rename numStops to stopCount for consistency with repeatCount.
Attachment #8436904 - Flags: review?(jmuizelaar) → review+
Attachment #8436903 - Flags: review?(jmuizelaar) → review+
Attachment #8436906 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8436903 [details] [diff] [review]
linear gradients

Requesting approval as a prerequisite for bug 989230. Details over there.
Attachment #8436903 - Flags: approval-mozilla-aurora?
Attachment #8436904 - Flags: approval-mozilla-aurora?
Attachment #8436906 - Flags: approval-mozilla-aurora?
Comment on attachment 8436903 [details] [diff] [review]
linear gradients

Aurora approval granted.
Attachment #8436903 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8436904 [details] [diff] [review]
radial gradients

Wanted to add that there's a decent amount of code change here. Do we have automated SVG tests? If not, can you do some manual verification of expected SVG rendering on Aurora one the set of patches lands?
Attachment #8436904 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8436906 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Lawrence Mandel [:lmandel] from comment #8)
> 
> Wanted to add that there's a decent amount of code change here. Do we have
> automated SVG tests? If not, can you do some manual verification of expected
> SVG rendering on Aurora one the set of patches lands?

Automated tests are in bug 989230
You need to log in before you can comment on or make changes to this bug.