1022624 - Implement support for gradients with ExtendMode::REFLECT in DrawTargetCG

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Markus Stange [:mstange]]

Attachment: linear gradients

Comment 1

[Markus Stange [:mstange]]

Attachment: radial gradients

Comment 2

[Markus Stange [:mstange]]

Attachment: share more code

Comment 3

[Markus Stange [:mstange]]

I should rename numStops to stopCount for consistency with repeatCount.

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c5a6ce4e2fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebe4b9991f91
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b76bb4c21c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/48dc31fc0fc4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9c5a6ce4e2fc
https://hg.mozilla.org/mozilla-central/rev/ebe4b9991f91
https://hg.mozilla.org/mozilla-central/rev/2b76bb4c21c2
https://hg.mozilla.org/mozilla-central/rev/48dc31fc0fc4

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8436903 [details] [diff] [review]
linear gradients

Requesting approval as a prerequisite for bug 989230. Details over there.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8436903 [details] [diff] [review]
linear gradients

Aurora approval granted.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8436904 [details] [diff] [review]
radial gradients

Wanted to add that there's a decent amount of code change here. Do we have automated SVG tests? If not, can you do some manual verification of expected SVG rendering on Aurora one the set of patches lands?

Comment 9

[Robert Longson [:longsonr]]

(In reply to Lawrence Mandel [:lmandel] from comment #8)
> 
> Wanted to add that there's a decent amount of code change here. Do we have
> automated SVG tests? If not, can you do some manual verification of expected
> SVG rendering on Aurora one the set of patches lands?

Automated tests are in bug 989230

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/610390beb394
https://hg.mozilla.org/releases/mozilla-aurora/rev/f3007d054fe2
https://hg.mozilla.org/releases/mozilla-aurora/rev/f5dc2ae02b19
https://hg.mozilla.org/releases/mozilla-aurora/rev/f0a87ca6c29d