1022699 - fix assertion-is-always-true warning in nsNavHistoryResult.cpp

Status: RESOLVED DUPLICATE of bug 992670

(Toolkit :: Places, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix assertion-is-always-true warning in nsNavHistoryResult.cpp

mAccessCount is an unsigned variable, so this assertion receives a warning.
Given that it's unsigned, it seems more correct to test that we didn't subtract
off too much.

Comment 2

[Marco Bonardo [:mak]]

we should just comment out the assertion for now, see bug 992670 that already had a patch to make the assertion test what it actually was meant to, but it bounced.

Unfortunately there is a bug somewhere in the code that makes us hit the assertion in some specific case (I think it's related to tag containers), and we need to figure what's that bug. The patch in bug 992670 partially solves some of the issues, but not all of them.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8436987 [details] [diff] [review]
fix assertion-is-always-true warning in nsNavHistoryResult.cpp

I will just disable the assertion in bug 992670 and file a bug to fix it.