1022705 - [Camera][Gecko] GonkCameraControl dtor has a worker thread dependency

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Destructor path winds up here:
http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraControl.cpp#1044

This assertion will fail if the GonkCameraControl object is destroyed on the Main Thread (or any other than the Camera Thread). Not sure what has caused this test to start failing all of a sudden

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Crash and stack trace:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41239098&tree=B2g-Inbound#error0

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=f68d7ebf5f5e

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

try-server push with bug 984274 test re-enabled: https://tbpl.mozilla.org/?tree=Try&rev=655ec7a79761

Comment 4

[Alfredo Yang (:alfredo)]

I got the same problem in https://bugzilla.mozilla.org/show_bug.cgi?id=984274#c176.
I think the StopImpl() in destructor is redundant, http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraControl.cpp#203 .

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Remove GonkCameraControl dtor thread dependency, v1

In short: only access 'mRecorder' inside a ReentrantMonitor.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8437616 [details] [diff] [review]
Remove GonkCameraControl dtor thread dependency, v1

Review of attachment 8437616 [details] [diff] [review]:
-----------------------------------------------------------------

StopRecordingImpl() needs to grab the monitor around mRecorder there too

::: dom/camera/GonkCameraControl.cpp
@@ +953,5 @@
>  {
>    MOZ_ASSERT(NS_GetCurrentThread() == mCameraThread);
>  
> +  ReentrantMonitorAutoEnter mon(mRecorderMonitor);
> +  

trailing space

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8437616 [details] [diff] [review]
Remove GonkCameraControl dtor thread dependency, v1

Review of attachment 8437616 [details] [diff] [review]:
-----------------------------------------------------------------

Never mind - is is there!

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Fix nit and land with test_sandbox_permission.html reenabled.

https://hg.mozilla.org/integration/b2g-inbound/rev/81b8673cd537

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81b8673cd537