1022712 - Investigate impact of bug 1022704 on update verification

Status: RESOLVED INACTIVE

(Toolkit :: Application Update, defect)

Description

[Gregory Szorc [:gps]]

The update service verifies downloads by first comparing file sizes. See https://hg.mozilla.org/mozilla-central/file/16f3cac5e8fe/toolkit/mozapps/update/nsUpdateService.js#l3955

As I reported in bug 1022704, nsIFile.fileSize can lie on Windows.

I discovered this file size as part of implementing the update hotfix in bug 1014194. The update hotfix verification code was effectively copied from nsUpdateService.js. I suspect this file size bug may be surfacing in nsUpdateService.js as well, causing the update service to reject completed downloads.

I'm not too familiar with the updater code. It's entirely possible this file size bug won't surface. If we want to be sure it won't, we can throw a "file.copy()" before accessing .fileSize as a workaround. That's what I'm doing in the hotfix.

Comment 1

[Benjamin Smedberg]

rstrong what do you think of the relative priority of this?

Comment 2

[Robert Strong (they/them - no direct email)]

Since it hasn't surfaced over the years I don't think we have seen this happening in app update or at the very least not often. I think getting bug 1022704 fixed should suffice.