1022748 - Include custom server URLs in Android Accounts.jsm launchSetup API

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is the bug tracking making Android's Accounts.jsm include custom server URLs.

Comment 1

[Nick Alexander :nalexander [he/him]]

ckarlof: this ticket is tracking modifying Accounts.jsm's launchSetup to include custom URLs.  I'll post a patch shortly.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Pass optional extras through Accounts.launchSetup. r=rnewman

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/463

Comment 4

[Nick Alexander :nalexander [he/him]]

The accompanying add-on that works with this (screen capture to follow) is at

https://github.com/ncalexan/fxa-custom-server-addon

ckarlof: the JS API that the addon calls looks like

Accounts.launchSetup({auth:"url", services:{sync:"url"}});

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8437960 [details] [diff] [review]
Part 1: Pass optional extras through Accounts.launchSetup. r=rnewman

Review of attachment 8437960 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserApp.java
@@ +1124,5 @@
>              final Intent intent = new Intent(getContext(), FxAccountGetStartedActivity.class);
>              intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
> +            final NativeJSObject extras = message.optObject("extras", null);
> +            if (extras != null) {
> +                intent.putExtra("extras", extras.toString());

Too lazy to look it up: does toString do the right thing, or should this be toJSONString?

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8437964 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/463

Notes in the pull request.

Comment 7

[Chris Karlof [:ckarlof]]

> ckarlof: the JS API that the addon calls looks like

> Accounts.launchSetup({auth:"url", services:{sync:"url"}});

I added some discussion here (Service Discovery API discussion) :

https://github.com/mozilla/fxa-auth-server/issues/738#issuecomment-46454827

about making authentication server configuration per-service. A default makes sense for when services don't want to delegate auth to specific service. 

"sync" vs "sync1.5"? I prefer "sync1.5".

It would be nice to support multiple urls for a service. E.g, in the "per-service auth delegation world", this might look something like: 

Accounts.launchSetup({ defaultAuth:"url", services: { sync1.5: { auth: "url", token: "url" }});

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Chris Karlof [:ckarlof] from comment #7)
> > ckarlof: the JS API that the addon calls looks like
> 
> > Accounts.launchSetup({auth:"url", services:{sync:"url"}});
> 
> I added some discussion here (Service Discovery API discussion) :
> 
> https://github.com/mozilla/fxa-auth-server/issues/738#issuecomment-46454827
> 
> about making authentication server configuration per-service. A default
> makes sense for when services don't want to delegate auth to specific
> service. 
> 
> "sync" vs "sync1.5"? I prefer "sync1.5".
> 
> It would be nice to support multiple urls for a service. E.g, in the
> "per-service auth delegation world", this might look something like: 
> 
> Accounts.launchSetup({ defaultAuth:"url", services: { sync1.5: { auth:
> "url", token: "url" }});

This is an interesting idea, and worth pursuing, but doesn't represent how Android works at the moment.  Right now, there's only one auth server and it's a centralized system.  I'm making the call that we should reflect the situation on the ground for now, until we take concrete steps to change the auth model on Android, so I'm going to land without this defaultAuth/auth split.

Comment 9

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/9da481fd4b5d
https://hg.mozilla.org/integration/fx-team/rev/e1f0b5ef74dc

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9da481fd4b5d
https://hg.mozilla.org/mozilla-central/rev/e1f0b5ef74dc

Comment 11

[Nick Alexander :nalexander [he/him]]

dev-doc is up at:

https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Accounts.jsm

rnewman had a quick once over.