1022764 - Build error in --disable-webrtc builds: "MediaManager.cpp:54:39: fatal error: browser_logging/WebRtcLog.h: No such file or directory"

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Build error, with up-to-date mozilla-central this morning, in a --disable-webrtc build:
{
dom/media/MediaManager.cpp:54:39: fatal error: browser_logging/WebRtcLog.h: No such file or directory
#include "browser_logging/WebRtcLog.h"
^
}

Comment 1

[Daniel Holbert [:dholbert]]

Looks like this #include was introduced here:
http://hg.mozilla.org/mozilla-central/diff/280077792878/dom/media/MediaManager.cpp

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1: Add #ifdef wrappers

This seems to fix things.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f90c888b85b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f90c888b85b

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8437036 [details] [diff] [review]
fix v1: Add #ifdef wrappers

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 970713 

User impact if declined: Unable to build Aurora (and then Beta, and then Release) with --disable-webrtc

Testing completed (on m-c, etc.): on m-c

Risk to taking this patch (and alternatives if risky): Minimal. This has zero effect on official builds -- just adding an #ifdef for a symbol that's known-to-be-defined in official builds. (so maybe arguably NPOTB, but I'm requesting approval to be on the safe side.

String or IDL/UUID changes made by this patch: none

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8437036 [details] [diff] [review]
fix v1: Add #ifdef wrappers

Aurora approval granted.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f9b60c46c1ed