SJCL should be unminified, versioned

RESOLVED FIXED in mozilla33

Status

Hello (Loop)
Client
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: abr, Assigned: abr)

Tracking

unspecified
mozilla33
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Source code in the tree is supposed to be readable rather than minified. Also, for tracking purposes, we should be able to determine which version of code is in use.
(Assignee)

Comment 1

4 years ago
Created attachment 8437038 [details] [diff] [review]
SJCL should be unminified, versioned
Attachment #8437038 - Flags: review?(standard8)
Comment on attachment 8437038 [details] [diff] [review]
SJCL should be unminified, versioned

Review of attachment 8437038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8
Attachment #8437038 - Flags: review?(standard8) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/projects/elm/rev/b8172fae3ff7
(Assignee)

Updated

4 years ago
Blocks: 1022871
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/b8172fae3ff7
Target Milestone: --- → mozilla33
Wonderful. But this is not the only minified library that's part of Loop, right? Is checking in the unminified source code of the others tracked by this bug, or are you planning to open a bug for each?

Gerv
(Assignee)

Comment 6

4 years ago
(In reply to Gervase Markham [:gerv] from comment #5)
> Wonderful. But this is not the only minified library that's part of Loop,
> right? Is checking in the unminified source code of the others tracked by
> this bug, or are you planning to open a bug for each?

See https://bugzilla.mozilla.org/showdependencytree.cgi?id=1022871&hide_resolved=1
This doesn't appear to need QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
Flags: qe-verify-
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.