Closed Bug 1022772 Opened 7 years ago Closed 7 years ago

SJCL should be unminified, versioned

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: abr, Assigned: abr)

References

Details

Attachments

(1 file)

Source code in the tree is supposed to be readable rather than minified. Also, for tracking purposes, we should be able to determine which version of code is in use.
Attachment #8437038 - Flags: review?(standard8)
Comment on attachment 8437038 [details] [diff] [review]
SJCL should be unminified, versioned

Review of attachment 8437038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8
Attachment #8437038 - Flags: review?(standard8) → review+
Blocks: 1022871
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Wonderful. But this is not the only minified library that's part of Loop, right? Is checking in the unminified source code of the others tracked by this bug, or are you planning to open a bug for each?

Gerv
(In reply to Gervase Markham [:gerv] from comment #5)
> Wonderful. But this is not the only minified library that's part of Loop,
> right? Is checking in the unminified source code of the others tracked by
> this bug, or are you planning to open a bug for each?

See https://bugzilla.mozilla.org/showdependencytree.cgi?id=1022871&hide_resolved=1
This doesn't appear to need QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
Flags: qe-verify-
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.