Closed
Bug 1022772
Opened 11 years ago
Closed 11 years ago
SJCL should be unminified, versioned
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: abr, Assigned: abr)
References
Details
Attachments
(1 file)
|
28.76 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Source code in the tree is supposed to be readable rather than minified. Also, for tracking purposes, we should be able to determine which version of code is in use.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8437038 -
Flags: review?(standard8)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8437038 [details] [diff] [review]
SJCL should be unminified, versioned
Review of attachment 8437038 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, r=Standard8
Attachment #8437038 -
Flags: review?(standard8) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla33
|
||
Comment 5•11 years ago
|
||
Wonderful. But this is not the only minified library that's part of Loop, right? Is checking in the unminified source code of the others tracked by this bug, or are you planning to open a bug for each?
Gerv
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #5)
> Wonderful. But this is not the only minified library that's part of Loop,
> right? Is checking in the unminified source code of the others tracked by
> this bug, or are you planning to open a bug for each?
See https://bugzilla.mozilla.org/showdependencytree.cgi?id=1022871&hide_resolved=1
This doesn't appear to need QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•