"ASSERTION: standard generic font family type required"

VERIFIED FIXED in Firefox 33

Status

()

Core
CSS Parsing and Computation
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Jesse Ruderman, Assigned: jtd)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla33
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox33 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8437062 [details]
testcase

###!!! ASSERTION: standard generic font family type required: 'aGenericType >= eFamily_serif && aGenericType <= eFamily_fantasy', file gfx/thebes/gfxFont.cpp, line 4877

This assertion was added in:
changeset:   https://hg.mozilla.org/mozilla-central/rev/e39cfafa8517
user:        John Daggett
date:        Fri Jun 06 15:09:23 2014 +0900
summary:     Bug 280443 p3 - use fontlist struct in gfx. r=roc,fredw
(Reporter)

Comment 1

3 years ago
Created attachment 8437063 [details]
stack
(Assignee)

Updated

3 years ago
Assignee: nobody → jdaggett
(Assignee)

Comment 2

3 years ago
Created attachment 8437370 [details] [diff] [review]
patch, treat -moz-fixed as monospace when resolving generics

This is an artifact of how -moz-fixed was handled prior to the fontlist struct changes in bug 280443. When -moz-fixed was the sole generic in a fontlist, it would set the font family to monospace and *also* set the size. However, when included with other fonts, it would be passed untranslated down to gfx and effectively ignored. Not sure the semantics of this "magic" name were well thought about but for now, just treat -moz-fixed as an alias for monospace within gfx.

David, please let me know if you think we should be making changes within the style system to accomodate this in a different way and I will file a new bug to make those changes.
Attachment #8437370 - Flags: review?(cam)
Flags: needinfo?(dbaron)
Attachment #8437370 - Flags: review?(cam) → review+
(Assignee)

Comment 3

3 years ago
Pushed to inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/100a14518e5b

Comment 4

3 years ago
https://hg.mozilla.org/mozilla-central/rev/100a14518e5b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Reproduced in Nightly 2014-06-09-mozilla-central-debug.
Verified fixed FF 33.0a1 2014-06-13-mozilla-central-debug Win 7 x64.
Status: RESOLVED → VERIFIED
status-firefox33: --- → verified
(In reply to John Daggett (:jtd) from comment #2)
> This is an artifact of how -moz-fixed was handled prior to the fontlist
> struct changes in bug 280443. When -moz-fixed was the sole generic in a
> fontlist, it would set the font family to monospace and *also* set the size.
> However, when included with other fonts, it would be passed untranslated
> down to gfx and effectively ignored. Not sure the semantics of this "magic"
> name were well thought about but for now, just treat -moz-fixed as an alias
> for monospace within gfx.

Treating -moz-fixed the same as monospace sounds fine.
Flags: needinfo?(dbaron)
You need to log in before you can comment on or make changes to this bug.