Closed Bug 1022971 Opened 10 years ago Closed 10 years ago

Rename Icon grid object to Mozapp

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files, 1 obsolete file)

Github patch
83 bytes, text/plain
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details
Follow-up commit (also uplift)
83 bytes, text/plain
Details 
We have an object named icon which is more generic than it really is. Let's rename this to be something like "mozapp" which will better describe what this object is for.
Attached file Github pull request (obsolete) — 
Waiting on a few patches to land before landing this as there will definitely be conflicts.
yes, better :)
Comment on attachment 8437375 [details] [review]
Github pull request

Hey guys, this renames the Icon Object to Mozapp, and namespaces all grid items under the GaiaGrid object. Just looking for an early review here, but will probably wait until we get some of the bigger patches landed that you guys are working on.
Attachment #8437375 - Flags: review?(jlal)
Attachment #8437375 - Flags: review?(crdlc)
QA Whiteboard: [VH-FC-blocking-]
This is nice to have, but this is mainly an engineering task that I want to land once most of the big patches are out of the way. Blocking bug 1017954 for now, but we may move this back later.
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
Comment on attachment 8437375 [details] [review]
Github pull request

Verbal R+ from James. Thanks!
Attachment #8437375 - Flags: review?(jlal)
Attachment #8437375 - Flags: review?(crdlc)
Attachment #8437375 - Flags: review+
Landed: https://github.com/mozilla-b2g/gaia/commit/1d0c3d4d2fdf4a02808b3477856ec127b696160c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: vertical-homescreen
No longer blocks: vertical-home-next
Comment on attachment 8437375 [details] [review]
Github pull request

This is necessary for the vertical homescreen. We've done extensive testing and believe this should cause no problems if uplifted.
Attachment #8437375 - Flags: approval-gaia-v2.0?(bbajaj)
Comment on attachment 8437375 [details] [review]
Github pull request

Found a tiny error in this one and want to correct it before uplift, so reverting and re-submitting.
Attachment #8437375 - Attachment is obsolete: true
Attachment #8437375 - Flags: approval-gaia-v2.0?(bbajaj)
Attached file Github patch — 
New commit with one minor typo change. This is necessary for the vertical homescreen and should be uplifted when possible. Thanks!
Attachment #8440309 - Flags: review+
Attachment #8440309 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8440309 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Whiteboard: [systemsfe]
Oops, the revert/re-landing caused some problems during uplift, fixed in a follow-up here: https://github.com/mozilla-b2g/gaia/commit/e8b8e2ab413e565ec47958340b89b44603ddd3a8
Hi Kevin,
Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!
Flags: needinfo?(kgrandon)
This is a refactoring issue. No need for verification.
Flags: needinfo?(kgrandon)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: