Rename Icon grid object to Mozapp

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.0 S4 (20june)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We have an object named icon which is more generic than it really is. Let's rename this to be something like "mozapp" which will better describe what this object is for.
(Assignee)

Comment 1

4 years ago
Created attachment 8437375 [details] [review]
Github pull request

Waiting on a few patches to land before landing this as there will definitely be conflicts.
yes, better :)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8437375 [details] [review]
Github pull request

Hey guys, this renames the Icon Object to Mozapp, and namespaces all grid items under the GaiaGrid object. Just looking for an early review here, but will probably wait until we get some of the bigger patches landed that you guys are working on.
Attachment #8437375 - Flags: review?(jlal)
Attachment #8437375 - Flags: review?(crdlc)
QA Whiteboard: [VH-FC-blocking-]
(Assignee)

Comment 4

4 years ago
This is nice to have, but this is mainly an engineering task that I want to land once most of the big patches are out of the way. Blocking bug 1017954 for now, but we may move this back later.
Blocks: 1017954
No longer blocks: 989848
(Assignee)

Comment 5

4 years ago
Comment on attachment 8437375 [details] [review]
Github pull request

Verbal R+ from James. Thanks!
Attachment #8437375 - Flags: review?(jlal)
Attachment #8437375 - Flags: review?(crdlc)
Attachment #8437375 - Flags: review+
(Assignee)

Comment 6

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/1d0c3d4d2fdf4a02808b3477856ec127b696160c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 989848
No longer blocks: 1017954
(Assignee)

Comment 7

4 years ago
Comment on attachment 8437375 [details] [review]
Github pull request

This is necessary for the vertical homescreen. We've done extensive testing and believe this should cause no problems if uplifted.
Attachment #8437375 - Flags: approval-gaia-v2.0?(bbajaj)
(Assignee)

Comment 8

4 years ago
Comment on attachment 8437375 [details] [review]
Github pull request

Found a tiny error in this one and want to correct it before uplift, so reverting and re-submitting.
Attachment #8437375 - Attachment is obsolete: true
Attachment #8437375 - Flags: approval-gaia-v2.0?(bbajaj)
(Assignee)

Comment 9

4 years ago
Created attachment 8440309 [details]
Github patch

New commit with one minor typo change. This is necessary for the vertical homescreen and should be uplifted when possible. Thanks!
Attachment #8440309 - Flags: review+
Attachment #8440309 - Flags: approval-gaia-v2.0?(bbajaj)
(Assignee)

Comment 10

4 years ago
Created attachment 8440494 [details]
Follow-up commit (also uplift)

Updated

4 years ago
Attachment #8440309 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Whiteboard: [systemsfe]
(Assignee)

Comment 12

4 years ago
Oops, the revert/re-landing caused some problems during uplift, fixed in a follow-up here: https://github.com/mozilla-b2g/gaia/commit/e8b8e2ab413e565ec47958340b89b44603ddd3a8
Hi Kevin,
Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!
Flags: needinfo?(kgrandon)
(Assignee)

Comment 14

3 years ago
This is a refactoring issue. No need for verification.
Flags: needinfo?(kgrandon)
You need to log in before you can comment on or make changes to this bug.