We have an object named icon which is more generic than it really is. Let's rename this to be something like "mozapp" which will better describe what this object is for.
Created attachment 8437375 [details] [review] Github pull request Waiting on a few patches to land before landing this as there will definitely be conflicts.
yes, better :)
Comment on attachment 8437375 [details] [review] Github pull request Hey guys, this renames the Icon Object to Mozapp, and namespaces all grid items under the GaiaGrid object. Just looking for an early review here, but will probably wait until we get some of the bigger patches landed that you guys are working on.
This is nice to have, but this is mainly an engineering task that I want to land once most of the big patches are out of the way. Blocking bug 1017954 for now, but we may move this back later.
Comment on attachment 8437375 [details] [review] Github pull request Verbal R+ from James. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8437375 [details] [review] Github pull request This is necessary for the vertical homescreen. We've done extensive testing and believe this should cause no problems if uplifted.
Comment on attachment 8437375 [details] [review] Github pull request Found a tiny error in this one and want to correct it before uplift, so reverting and re-submitting.
Created attachment 8440309 [details] Github patch New commit with one minor typo change. This is necessary for the vertical homescreen and should be uplifted when possible. Thanks!
Attachment #8440309 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
v2.0: https://github.com/mozilla-b2g/gaia/commit/ca7760eb424743ddde6d21426a161d0580806bc1 v2.0: https://github.com/mozilla-b2g/gaia/commit/78d6f4075fb12f483b90286b97e30c8c9a8031b9
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Oops, the revert/re-landing caused some problems during uplift, fixed in a follow-up here: https://github.com/mozilla-b2g/gaia/commit/e8b8e2ab413e565ec47958340b89b44603ddd3a8
Hi Kevin, Could you please provide the detailed reproduce steps or video for me to verify this bug? Thank you very much!
This is a refactoring issue. No need for verification.
You need to log in before you can comment on or make changes to this bug.