1023012 - [Flatfish][Settings] Text at header is not show properly

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Raniere Silva]

Attachment: settings.png

Environment Information:

OS version: 2.0.0.0-prerelease
Firmware revision: flatfish_20140519-1653
Hardware revision: flatfish
Platform version: 32.0a1
Build Identifier: 20140519171236
Gaia revision: a2d8629

Steps to Reproduce:

1. Open Settings App
2. Select one item from the list
	 
Actual Results:

The text at the header has '...' (view attachment).
	 
Expected Results:

No '...' at the text.

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Seems strictly a 2.0+ issue.

Comment 2

[Anuj Agarwal [:anujagarwal464]]

I was able reproduce this bug on

OS version: 2.1.0.0-prerelease
Firmware revision: flatfish_20140613-2011
Hardware revision: flatfish
Platform version: 32.0a1
Build Identifier: 20140613213830
Gaia revision: aa125bd4

Comment 3

[Théo Chevalier]

Regression from Bug 908300

Comment 4

[Théo Chevalier]

Note, every header in Settings are truncated as on attached screenshot, all locales (en-US included) are affected.

Comment 5

[Cameron McCormack (:heycam)]

I think the issue is that font_size_utils.js is assuming that the maximum space available for the header is the screen width, when really it should be using the width of the right column of the Settings app's tablet view.  On phones each settings panel takes up the whole width of the screen, so the problem doesn't appear there.

Comment 6

[Cameron McCormack (:heycam)]

Attachment: pr

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8463054 [details] [review]
pr

This is a good solution. We just need to fix the unit and linting tests. For the unit tests, previously we used to shim that function getWindowWidth to fake a width, but now we will just need to set the parent container to that same width [1].

I want to see the updated tests before giving it the r+.

1.) https://github.com/mozilla-b2g/gaia/blob/b2c9d27b01a6bb04c81ca47d36d55dc5c3c6788e/apps/sharedtest/test/unit/font_size_utils_test.js#L534

Comment 12

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This seems mostly fixed with the latest 20140912 build from the vendor. 

Only thing that pops out if "Themes:

Comment 14

[Cameron McCormack (:heycam)]

I don't have time right now to follow up on this bug, so anyone should feel free to revise the patch with the tests requested to help bring it over the line.

Comment 15

[YF (Yang)]

to WFM? In the recent build not see the ellipsis.

Comment 16

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

(In reply to YF (Yang) from comment #15)
> to WFM? In the recent build not see the ellipsis.

I'll look into this. If anybody does so, please comment and remove ni? from me. Thanks.

Comment 17

[BMO Automation]

Firefox OS is not being worked on