1023028 - xpcom/string/src/nsUTF8UtilsSSE2.cpp: error: #error "SSE2 instruction set not enabled"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

Attachment: move under GNU_CC block

Bug 979118 replaced GNU_CC ifdefs with OS-specific SSE2_FLAGS. As not every platform is special-cased in configure.in absence of -msse2 leads to an error later in the build. At least DragonFly, FreeBSD and GNU/kFreeBSD are affected.

In file included from xpcom/string/src/nsUTF8UtilsSSE2.cpp:7:0:
/usr/local/lib/gcc48/gcc/i386-portbld-freebsd9.1/4.8.4/include/emmintrin.h:31:3: error: #error "SSE2 instruction set not enabled"
 # error "SSE2 instruction set not enabled"
   ^
xpcom/string/src/nsUTF8UtilsSSE2.cpp: In member function 'void LossyConvertEncoding16to8::write_sse2(const char16_t*, uint32_t)':
xpcom/string/src/nsUTF8UtilsSSE2.cpp:25:3: error: '__m128i' was not declared in this scope
   __m128i vectmask = _mm_set1_epi16(0x00ff);
   ^

Comment 1

[Jan Beich]

Can someone push to Try?

try: -b o -p all -u none -t none

Comment 2

[Jan Beich]

Comment on attachment 8437400 [details] [diff] [review]
move under GNU_CC block

Let's backport to help downstream not carry around i386 buildfix for esr31 lifetime.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 979118
User impact if declined: broken build on dragonfly i386, freebsd i386, debian/kfreebsd i386
Testing completed (on m-c, etc.): soon
Risk to taking this patch (and alternatives if risky): Low, broken build at most.
String or IDL/UUID changes made by this patch: None

Comment 3

[Jan Beich]

Landry, can you help with Try push?

Comment 4

[Mike Hommey [:glandium]]

Why don't you ask for commit access for try?

Comment 5

[Landry Breuil (:gaston)]

He doesnt want to disclose his real identity....

https://tbpl.mozilla.org/?tree=Try&rev=2fa0230ffd35

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bca9fe3d4cf7

Friendly reminder that your commit message should be summarizing what the patch is actually doing, not just restating the problem it's fixing. Thanks!
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bca9fe3d4cf7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58a37a5bd03b
https://hg.mozilla.org/releases/mozilla-beta/rev/b6a50388d168