Closed Bug 1023053 Opened 7 years ago Closed 7 years ago
[Calendar] Clean up useless images
Hi these images listed below are no longer used in visual refresh 2.0 Can you help to clear them all? reference bug(https://bugzilla.mozilla.org/show_bug.cgi?id=1011687) ./apps/calendar/style/ui/drawer.png ./apps/calendar/style/ui/drawer_shadow.png ./email@example.com ./apps/calendar/style/ui/header.png ./apps/calendar/style/ui/progress.png ./apps/calendar/style/ui/shadow-header.png ./firstname.lastname@example.org thanks for your help Peko
Hey Peko, I remove all images except one `apps/calendar/style/ui/progress.png`. We still have some logic who use this image and I'm not sure that we need to remove it now ... if you are not sure maybe we need to ask someone who works on calendar to confirm that and remove the logic.
Attachment #8437468 - Flags: ui-review?(pchen)
Hi Evan, Can you please help to double confirm `apps/calendar/style/ui/progress.png` this image? and see is it still use for visual refresh 2.0? thanks for your help~~ Peko
Hi Please also remove these images, thank you so much!! ./apps/calendar/style/icons/alarm.png ./email@example.com ./firstname.lastname@example.org
PR is now updated :)
Hi Peko, Yes, the `apps/calendar/style/ui/progress.png` image is still used in v2.0.
Comment on attachment 8437468 [details] [review] patch for Gaia/master thanks for your great work.
Attachment #8437468 - Flags: ui-review?(pchen) → ui-review+
Attachment #8437468 - Flags: review?(kgrandon)
Comment on attachment 8437468 [details] [review] patch for Gaia/master I feel like I am still qualified to review this one :)
Attachment #8437468 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.