Gaia related tests should run |git log -n 1| in it's log output

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: timdream, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We now have wonderful feature allowing people to run Try with their Gaia branch on Github.

https://wiki.mozilla.org/ReleaseEngineering/TryServer#Using_a_custom_Gaia

However log such as this one

https://tbpl.mozilla.org/php/getParsedLog.php?id=41407640&tree=Try&full=1

Does not actually tell me which commit it picked up. Given the fact Gaia developers rebase/force push their branches all the time I recommend we should print |git log -n 1| in the log.

Jonathan, did I file this bug in the correct component? This is also trivial enough in which I feel I could contribute if you give me a pointer.
Flags: needinfo?(jgriffin)
Yes, this is the correct component.  Where in the UI do you think this information should be reflected?
Flags: needinfo?(jgriffin)

Comment 2

3 years ago
Isn't that this block?
http://hg.mozilla.org/build/mozharness/file/c24c4326bea3/mozharness/mozilla/gaia.py#l107
Yes, maybe we just need to wrap that in a TinderboxPrint so it shows up more accessibly in TBPL.
(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> Yes, this is the correct component.  Where in the UI do you think this
> information should be reflected?

My original intention was simply print the commit hash in the log, but if we could show it somewhere in the UI it would be great too. I have no opinion on where it should be shown.

(In reply to Aki Sasaki [:aki] from comment #2)
> Isn't that this block?
> http://hg.mozilla.org/build/mozharness/file/c24c4326bea3/mozharness/mozilla/
> gaia.py#l107

Yes, however as you can see it runs |git branch| instead of |git log -1| when |revision| exists. I think we should run |git log -1| regardless of the existence of |revision| since branch name is not a definite pointer to code change in our use cases.

Comment 5

3 years ago
Created attachment 8438764 [details] [diff] [review]
gitlog
Attachment #8438764 - Flags: review?(jgriffin)
Comment on attachment 8438764 [details] [diff] [review]
gitlog

Review of attachment 8438764 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8438764 - Flags: review?(jgriffin) → review+

Comment 7

3 years ago
Comment on attachment 8438764 [details] [diff] [review]
gitlog

https://hg.mozilla.org/build/mozharness/rev/fc8bccfd9e39
Attachment #8438764 - Flags: checked-in+
In prod with reconfig on 2014-06-12 10:46 PT
Thanks guys!

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.