1023111 - if input wrong pin number, the input box will be covered up by keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Wei Gao (Spreadtrum)]

Attachment: screenshot_083046.jpg

OS version
---------------------------------------------
FireFoxOS v1.3 in 6821

Reproduce steps:
---------------------------------------------
Start phone -> input wrong pin number

Actual result:
---------------------------------------------
The input box will be covered up by keyboard

Expected result:
---------------------------------------------
The input box should scroll up 

Probability:
---------------------------------------------
Always Recurrence

Comment 1

[Wei Gao (Spreadtrum)]

Attachment: Bug1023111_scroll_input_pin.patch

This is a patch to scroll simpin input box.

Can you help to review it?

Thanks very much.

Comment 2

[Wei Gao (Spreadtrum)]

Hi James

Please help to push this bug.
Thanks.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8437491 [details] [diff] [review]
Bug1023111_scroll_input_pin.patch

It make sense to land this in System app than keep figuring out how to make forms.js behave correctly here.

We should land this on master too.

Comment 4

[Wei Gao (Spreadtrum)]

Attachment: master: scroll pin input page to show pin input box.

Hi Tim

I have commited a pull request to master.
As it is a master code, I can't test it by myself.
Can you help to review it?
Thanks.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8445649 [details] [review]
master: scroll pin input page to show pin input box.

Code looks good, but please fix linter error and unit test error.

https://travis-ci.org/mozilla-b2g/gaia/builds/28374422

You can find out how to write/run unit test with
https://github.com/mozilla-b2g/gaia#unit-tests

Comment 6

[Wei Gao (Spreadtrum)]

https://github.com/mozilla-b2g/gaia/pull/21407

Hi Tim

That's my PR.
I removed "KeyboardManager", but there still have errors in CI test.
I wonder why it happened?
Could you help me? 
Thanks.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Unit tests passes on TBPL so it's probably not worthy checking what's wrong on Travis-CI since the error might not be related.

https://tbpl.mozilla.org/?rev=d1cc4122c9fe1238be23e10ed07dfd578c2dbab6&tree=Gaia-Try

We can land this patch first based on that assumption.

If the assumption is wrong we can always backout the patch later :)

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/43c54f758c614160b0183429021ea974bc988905

Thank you for your fix!

Comment 9

[Wei Gao (Spreadtrum)]

https://github.com/mozilla-b2g/gaia/pull/21430

Hi Tim
Thanks for your review.
Could this PR be merged into v1.3t?
Thanks a great.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.3t: https://github.com/mozilla-b2g/gaia/commit/94959ce5a66bec034f290f1f7d0a0af410746cc4

Comment 11

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/5

Flame v2.1 version:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0