1023256 - [Flame][v1.4][Gaia::SMS] The contact’s photo disappeared in the thread view of message screen after update the contact.

Status: RESOLVED DUPLICATE of bug 994553

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[greatwall2686]

Attachment: disappear2014-06-10-21-42-25.rar

* Description:
The contact’s photo disappeared in the thread view of message screen after update the contact (except the phone number).
* Precondition:
  There is a contact A which contain photo, name and phone number in the phone book
* Reproduction steps:
  1. Open [SMS] app and send a message to contact A.
  2. Open [Contacts] app 
  3. Update contact A in contact edit page, such as add a phone number.
  4. Open [SMS] app and check the thread view displayed.

* Expected result:
The contact’s name, photo and time is shown correctly.
* Actual result: 
The contact’s photo is shown disappear.

* Reproduction build:(Buri - Firefox OS V1.4 inside)
 - Gaia      17b102ee8d9a724b62285547cc5f1c5d30bfb01c
 - Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/95be84248033
 - BuildID   20140520000201
 - Version   30.0

* Reproduction Frequency
  - 100%

Comment 1

[Julien Wajsberg [:julienw]]

Can we please check on master?

I think I recall we fixed this already. Or it's bug 994553.

Comment 2

[Ross Kuhlman ([e-mail])]

The contact picture updates appropriately in Messaging app on todays v2.0. Unable to repro the issue.

v2.0 Environmental Variables
Device: Flame v2.0
BuildID: 20140613000203
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 8897bc43f59b
Firmware Version: v121-2

The issue DOES reproduce on todays v1.4 build.

v1.4 Environmental Variables
Device: Flame v1.4
BuildID: 20140613000202
Gaia: 1dae62556e642b0b2e08689e35e24e56daa8c79b
Gecko: 30224c7f5e58
Version: 30.0
Firmware Version: v121-2

Comment 3

[Julien Wajsberg [:julienw]]

Reading the code, it can definitely be bug 994553 but then I don't know why it would work in v2 from 2 days ago (bug 994553 was even not in master yet).

I won't do more work on this unless it's made v1.4+ blocker. Otherwise let's just close it.

QA: can we please know the behavior in v1.3?

Comment 4

[Natalya Kot [:nkot]]

I've checked this on 1.3 Buri and on Flame (base image), and the issue does NOT reproduce 
- update contact picture in Contacts app --> open Messages app with the existing thread with this contact ==>  the updated contact picture will display

Same happens on the latest master (2.1)

The issue still reproduces on Flame 1.4 (06/25 build) - after updating picture in Contacts, the picture won't display in Messages as per comment 0

Env. variables:
Buri 1.3 - NO REPRO
BuildID: 20140616024002
Gaia: 8d6bd6c484557c5322bf14798a4273d2a8f4300f
Gecko: dc92670d5413
Version: 28.0

Flame 2.1 (master) - NO REPRO
BuildID: 20140626040205
Gaia: 87a7746568ac5708e828026160c0732ba252300f
Gecko: c43be7e4ec49
Version: 33.0a1

Flame 1.4 - REPRO
BuildID: 20140625000201
Gaia: c9416de14acf9e94ab006619cd2418c768422fcb
Gecko: cddf88f78632
Version: 30.0

Comment 5

[Julien Wajsberg [:julienw]]

Triagers: should we block on this?

I can see how annoying it could be but I wouldn't hold a release for this.

Comment 6

[Ivan Tsay (:ITsay)]

Per comment 3, can we just try to uplift the patch to 1.4 from bug 994553 to resolve this issue?

Comment 7

[Wayne Chang [:wchang]]

Regression and broken feature, let's fix it on 1.4.

Comment 8

[Steve Chung [:steveck]]

Hi Ivan, please uplift bug 994553 first. I think we could close this bug unless it's still reproducible after uplifted.

(In reply to Julien Wajsberg [:julienw] from comment #5)
> Triagers: should we block on this?
> 
> I can see how annoying it could be but I wouldn't hold a release for this.

Since it's an intermittent issue like you said in bug 994553 comment 34, it's still possible to show the potrait without patch.