1023259 - [Flame][v1.4][Gaia::SMS] The contact number is shown incompletely in the contact detail screen of SMS conversion when the contact phone label is more than 19 characters.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[greatwall2686]

Attachment: phone number display2014-06-10-21-24-34.rar

* Description:
The contact number is shown incompletely in the contact detail screen of SMS conversion when the contact phone label is more than 19 characters.
* Precondition:
  There is a contact A which has phone label more than 19 characters in the phone book.
* Reproduction steps:
  1. Open [Message] app and create new a message.
  2. Tap on “+” icon and select contact A in the contacts list.
  3. Write the SMS text and send it.
  4. Click contact A name and check the displayed.
* Expected result:
The contact’s name, photo and phone number is shown correctly.
* Actual result: 
A part of the contact number is cover by photo box.

* Reproduction build:(Buri - Firefox OS V1.4 inside)
 - Gaia      17b102ee8d9a724b62285547cc5f1c5d30bfb01c
 - Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/95be84248033
 - BuildID   20140520000201
 - Version   30.0

* Reproduction Frequency
  - 100%

Comment 1

[Julien Wajsberg [:julienw]]

Can we check on master please?

Comment 2

[Dean R. Gomez (DeanG)]

This issue DOES occur on Flame 2.1

2.1 Environmental Variables:
Device: Flame 2.1
Build ID: 20140609223003
Gaia: f42ebc93554979501d3ac52bcf9e69cb4b310a4f
Gecko: 9dc0ffca10f4
Version: 33.0a1 (2.1) 
Firmware Version: v10G-2

Comment 3

[Steve Chung [:steveck]]

This issue is always there, but we merely change the type manually. ni? visual to confirm that show ellipsis for the contact details is sufficient in this case(same behavior for long contact name). It should be an quick css fixing for showing ellipsis so flag a good first bug for contributor.

Comment 4

[Victoria Gerchinhoren [:vicky]]

(In reply to Steve Chung [:steveck] from comment #3)
> This issue is always there, but we merely change the type manually. ni?
> visual to confirm that show ellipsis for the contact details is sufficient
> in this case(same behavior for long contact name). It should be an quick css
> fixing for showing ellipsis so flag a good first bug for contributor.

I don't know if I understood this correctly, but the issue is that in Contact details there's no place to see the full contact name when it's long?

Comment 5

[Julien Wajsberg [:julienw]]

No, the contact name has an ellipsis already, the issue is for the contact detail (the phone number, or maybe in the future the email).

Comment 6

[Victoria Gerchinhoren [:vicky]]

We can use elipsis here as well. Please set the maximum width of that line 1 rem before the image thumbnail.

Comment 7

[Dorian [:munto]]

Attachment: test.patch

Add an ellipsis for the details of a contact

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8444139 [details] [diff] [review]
test.patch

Review of attachment 8444139 [details] [diff] [review]:
-----------------------------------------------------------------

Hey,

this works fine for the case of the number belongs to a known contact, but not when the number is unknown. Could you please check this case?

Comment 9

[talhaanwar.anwar]

anyone working on this? If not, i will be happy to take it. But i would require mentoring as I am new here.

Comment 10

[Julien Wajsberg [:julienw]]

Hey dear Talhaanwar, 

Munto was working on this bug already (despite he  was not added as assignee). Munto, are you still working on this?

Comment 11

[talhaanwar.anwar]

I am Talha :-). No problem Julien.

Comment 12

[raj454raj]

Is there anyone still working on this bug as this would be my first one if you let me do so!!!

Comment 13

[Steve Chung [:steveck]]

(In reply to raj454raj from comment #12)
> Is there anyone still working on this bug as this would be my first one if
> you let me do so!!!

Since it's over 2 weeks after ni but no responds, I'll reassign to other contributor who is also interested in the issue. Hi Talha and raj454raj, please leave comment below if you could help with fixing, thanks!

Comment 14

[Goutam(:goutamnair)]

Hey, i would like to work on this. Does this require a DuT?

Comment 15

[Steve Chung [:steveck]]

(In reply to Goutam from comment #14)
> Hey, i would like to work on this. Does this require a DuT?

We don't have a strong deadline for this issue now, so take your time :)
Please follow this rule[1] once you finish your patch

Hi Munto, sorry that transferring the assignee to Goutam, but please let me know if you are still working on this, thanks.


[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch

Comment 16

[Goutam(:goutamnair)]

Attachment: PR for Bug

Comment 17

[Goutam(:goutamnair)]

Can you please review the PR?

Comment 18

[Steve Chung [:steveck]]

Comment on attachment 8489003 [details] [review]
PR for Bug

Hi Goutam, this patch works fine, thanks for the contribution! next time please remember to leave more description on the github PR title instead of bug number only.

Sorry munto, you submit the patch at first. But next time please provide the github patch for merging to gaia master, thanks.

Comment 19

[Steve Chung [:steveck]]

master: 32d82d288abe2e55146c10c066234e8ba4982836