Rename dictionary.ToObject

RESOLVED FIXED in mozilla33

Status

()

defect
RESOLVED FIXED
5 years ago
3 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

29 Branch
mozilla33
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
In the new world ToJSValue should be used, and not dictionary.ToObject.
(Currently ToJSValue just calls ToObject).

We should rename ToObject to something which hints that it shouldn't be used.
ToObjectInternal for example.
Assignee

Comment 1

5 years ago
I may have missed some b2g stuff.

https://tbpl.mozilla.org/?tree=Try&rev=0210eba6ac04
Attachment #8437883 - Flags: review?(bzbarsky)
Comment on attachment 8437883 [details] [diff] [review]
ToObjectInternal

r=me

Please do the try run on b2g and update the webidl docs?
Attachment #8437883 - Flags: review?(bzbarsky) → review+
Assignee

Comment 3

5 years ago
checkin-needed because m-i seems to be rather closed today.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1972ca2531d9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.