Closed
Bug 1023280
Opened 10 years ago
Closed 10 years ago
Rename dictionary.ToObject
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
28.18 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
In the new world ToJSValue should be used, and not dictionary.ToObject. (Currently ToJSValue just calls ToObject). We should rename ToObject to something which hints that it shouldn't be used. ToObjectInternal for example.
|
Assignee | |
Comment 1•10 years ago
|
||
I may have missed some b2g stuff. https://tbpl.mozilla.org/?tree=Try&rev=0210eba6ac04
Attachment #8437883 -
Flags: review?(bzbarsky)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8437883 [details] [diff] [review] ToObjectInternal r=me Please do the try run on b2g and update the webidl docs?
Attachment #8437883 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
checkin-needed because m-i seems to be rather closed today.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1972ca2531d9
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1972ca2531d9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•