1023305 - [v1.4] [Flame] Investigate failure in test_gallery_crop_photo

Status: RESOLVED DUPLICATE of bug 1021027

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Viorela Ioia [:viorela]]

The test_gallery_crop_photo failed in the latest v1.4 build. I was able to reproduce the failure locally, by running the automated test. The problem is that the scale attribute of the image has a smaller value after we crop the photo, than it had initially(before crop). 
That scale is supposed to be bigger after we crop the photo. 
We should investigate the issue here and try to fix it. Maybe also compare with the code on master. 

Traceback (most recent call last):
  File "/home/viorelaioia/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_crop_photo.py", line 42, in test_gallery_crop_photo
    self.assertLess(initial_scale, image1.current_scale)
TEST-UNEXPECTED-FAIL | test_gallery_crop_photo.py test_gallery_crop_photo.TestGalleryCropPhoto.test_gallery_crop_photo | AssertionError: u'0.5, 0.5' not less than u'0.40201, 0.40201'

Gaia      57c6a24f7c7d16aac132f3cecd3ff9ee8d53cf78
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/54a7aa1a0423
BuildID   20140610000204
Version   30.0
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Jenkins report: http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Flame/job/b2g.flame.mozilla-b2g30_v1_4.ui.non-smoketest/14/HTML_Report/

Comment 1

[Jason Smith [:jsmith]]

This is a bug in the test, not a gaia bug, right?

Comment 2

[[:AndreiH]]

As far as I know we are using the "scale" attribute to see if the image has a new size.
This seems to have changed from 0.5 to 0.40201, so we need to change our test.
The functionality is all alright. :)

Comment 3

[[:AndreiH]]

As far as I know we are using the "scale" attribute to see if the image has a new size.
This seems to have changed from 0.5 to 0.40201, so we need to change our test.
The functionality is all alright. :)

Comment 4

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/20367

I don't know that the theory applies here.
I don't really know what is the relationship between scale vs size, but what if we check that they are different.
I mean the functionality of the crop function works ok.

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8438467 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/20367

This allows the test to pass, but I'm not sure the logic is OK. See PR for details.

Comment 6

[Viorela Ioia [:viorela]]

The issue here was fixed by https://github.com/mozilla-b2g/gaia/commit/4eb1c2e77be24bcf2e24e198208148a5e8fdca40, which is in the current build.
We no longer need to make changes to this test, others than updating the locator in https://github.com/mozilla-b2g/gaia/blob/v1.4/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py#L14.
There's an opened bug on master for changing the locator (Bug 1021027). 
After the pull with the changes is merged on master, we will uplift it to v1.4
Closing this for now.