Closed
Bug 1023399
Opened 10 years ago
Closed 10 years ago
--disable-ion build fails: js/src/gc/ForkJoinNursery.h:20:2: error: "JS_ION is required for the ForkJoinNursery"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file, 1 obsolete file)
|
968 bytes,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
In file included from js/src/builtin/RegExp.cpp:18:
In file included from js/src/jsobjinlines.h:21:
In file included from js/src/jsgcinlines.h:13:
In file included from js/src/vm/ForkJoin.h:16:
js/src/gc/ForkJoinNursery.h:20:2: error: "JS_ION is required for the
ForkJoinNursery"
#error "JS_ION is required for the ForkJoinNursery"
^
1 error generated.
http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1578/steps/shell/logs/stdio
Attachment #8437779 -
Flags: review?(lhansen)
Actually, just moz.build change is enough.
Attachment #8437779 -
Attachment is obsolete: true
Attachment #8437779 -
Flags: review?(lhansen)
Attachment #8437781 -
Flags: review?(lhansen)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8437781 [details] [diff] [review]
v2
Review of attachment 8437781 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, that's the right fix for now.
Attachment #8437781 -
Flags: review?(lhansen) → review+
No Try build because trivial to test locally: --enable-ion, --disable-ion.
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•