Closed Bug 1023399 Opened 6 years ago Closed 6 years ago

--disable-ion build fails: js/src/gc/ForkJoinNursery.h:20:2: error: "JS_ION is required for the ForkJoinNursery"

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
In file included from js/src/builtin/RegExp.cpp:18:
In file included from js/src/jsobjinlines.h:21:
In file included from js/src/jsgcinlines.h:13:
In file included from js/src/vm/ForkJoin.h:16:
js/src/gc/ForkJoinNursery.h:20:2: error: "JS_ION is required for the
      ForkJoinNursery"
#error "JS_ION is required for the ForkJoinNursery"
 ^
1 error generated.

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1578/steps/shell/logs/stdio
Attachment #8437779 - Flags: review?(lhansen)
Attached patch v2Splinter Review
Actually, just moz.build change is enough.
Attachment #8437779 - Attachment is obsolete: true
Attachment #8437779 - Flags: review?(lhansen)
Attachment #8437781 - Flags: review?(lhansen)
Comment on attachment 8437781 [details] [diff] [review]
v2

Review of attachment 8437781 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, that's the right fix for now.
Attachment #8437781 - Flags: review?(lhansen) → review+
No Try build because trivial to test locally: --enable-ion, --disable-ion.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d2d875512712
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.