1023472 - Fix and re-enable test_bug935876.html on Android

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Looks like bug 1021644 redux. This time bug 988616 gets to be the "regressor".

1.) Chunking changes push test into new chunk.
2.) Test starts perma-failing.
3.) Test gets disabled so we can re-open the tree.
4.) ..
5.) Profit

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99eee26d1017

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Sorry, forgot to include the log link:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41456530&tree=Mozilla-Inbound

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that somebody calls stopPropagation() or stopImmediatePropagation() before key events fired on <select> elements. If it's not fired in content level, they are serious regression because web apps cannot handle key events.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged to m-c in https://hg.mozilla.org/mozilla-central/rev/99eee26d1017

Backed out and relanded in https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get around m-c's commit hook requiring "a=merge" because pulling from inbound didn't create a merge commit.

Comment 5

[Ed Morley [:emorley]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> Backed out and relanded in
> https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get
> around m-c's commit hook requiring "a=merge" because pulling from inbound
> didn't create a merge commit.

That diff is empty. There was no need to back anything out - just either temporarily change the tree state using treestatus, or 'hg qnew temp.diff -m "No-op merge commit for tree hook (no bug); a=merge"'. Note the commit message must contain "no bug" since the "Merge doesn't need a bug number" exception only applies if the number of heads was >1.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This is affecting mozilla-beta too now that the number of chunks was increased from 12 to 16.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: Running the test even on only one platform, it's enough to test the code. So, Feel free to disable it on branches too.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> FYI: Running the test even on only one platform, it's enough to test the
> code. So, Feel free to disable it on branches too.

Oops, sorry, I posted this comment to wrong bug :-(

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1764a68fe1ae

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This is running on Android again nowadays.