Fix and re-enable test_bug935876.html on Android

NEW
Unassigned

Status

()

defect
5 years ago
4 months ago

People

(Reporter: RyanVM, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [test disabled on Android][leave open])

Looks like bug 1021644 redux. This time bug 988616 gets to be the "regressor".

1.) Chunking changes push test into new chunk.
2.) Test starts perma-failing.
3.) Test gets disabled so we can re-open the tree.
4.) ..
5.) Profit
Blocks: 988616, 1021644
https://hg.mozilla.org/integration/mozilla-inbound/rev/99eee26d1017
Summary: Fix and re-enable test_bug935876.html on Android 2.3 → Fix and re-enable test_bug935876.html on Android
Whiteboard: [test disabled on Android 2.3][leave open] → [test disabled on Android][leave open]
Looks like that somebody calls stopPropagation() or stopImmediatePropagation() before key events fired on <select> elements. If it's not fired in content level, they are serious regression because web apps cannot handle key events.
Merged to m-c in https://hg.mozilla.org/mozilla-central/rev/99eee26d1017

Backed out and relanded in https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get around m-c's commit hook requiring "a=merge" because pulling from inbound didn't create a merge commit.
(In reply to Wes Kocher (:KWierso) from comment #4)
> Backed out and relanded in
> https://hg.mozilla.org/mozilla-central/rev/b9f589c4d2e7 so I could get
> around m-c's commit hook requiring "a=merge" because pulling from inbound
> didn't create a merge commit.

That diff is empty. There was no need to back anything out - just either temporarily change the tree state using treestatus, or 'hg qnew temp.diff -m "No-op merge commit for tree hook (no bug); a=merge"'. Note the commit message must contain "no bug" since the "Merge doesn't need a bug number" exception only applies if the number of heads was >1.
This is affecting mozilla-beta too now that the number of chunks was increased from 12 to 16.
FYI: Running the test even on only one platform, it's enough to test the code. So, Feel free to disable it on branches too.
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> FYI: Running the test even on only one platform, it's enough to test the
> code. So, Feel free to disable it on branches too.

Oops, sorry, I posted this comment to wrong bug :-(
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.